----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108201/#review24738 -----------------------------------------------------------
Good start! Unfortunately I can't comment on the conversion itself since I don't know much about multimedia content in epub3 files. But there were a couple of question marks inside that I would like either a fix for or a comment upon. I also wonder, can the filter handle multimedia contents stored both outside or inside the odt? If not, I think we should add that to it. I think (but am not sure) that the video shape always uses external video files, right? filters/words/epub/OdtHtmlConverter.cpp <http://git.reviewboard.kde.org/r/108201/#comment19003> Hmm, what happens when there is more than one video in a chapter? Won't they get the same ID? filters/words/epub/OdtHtmlConverter.cpp <http://git.reviewboard.kde.org/r/108201/#comment19004> Reference is spelled "reference" :) filters/words/epub/OdtHtmlConverter.cpp <http://git.reviewboard.kde.org/r/108201/#comment19005> Are you hard coding all media to audio here? That would exclude videos, wouldn't it? - Inge Wallin On Jan. 5, 2013, 1:27 p.m., mojtaba shahi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108201/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2013, 1:27 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Add Media support for epub3. For this feature we need a new file .smil (SMIL > ML) that contains the media refrence. > > > Diffs > ----- > > filters/words/epub/OdtHtmlConverter.h 0245b9d > filters/words/epub/OdtHtmlConverter.cpp d19ef54 > filters/words/epub/exportepub2.h 798f9c6 > filters/words/epub/exportepub2.cpp 268455b > filters/words/epub/exporthtml.cpp 03aa7b5 > > Diff: http://git.reviewboard.kde.org/r/108201/diff/ > > > Testing > ------- > > > Thanks, > > mojtaba shahi > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
