> On Jan. 2, 2013, 10:16 p.m., Jarosław Staniek wrote: > > I compiled/checked your changes, thanks for attention to details. > > > > 1. How about using KDialogButtonBox instead of QDialogButtonBox? (it's > > available in Qt Designer too) > > > > 2. While we're moving to QFormLayout I propose to fix checkboxes in one go, > > see http://wstaw.org/m/2013/01/02/plasma-desktopnq2207.png > > i.e. "Show Group Header" -> "Show group header:", etc. > > > > 3. BTW, please fix capitalization in the same patch, all 3 check boxes > > mentioned above need this fix, and also 12 checkboxes in the Section Editor > > > > 4. I propose to replace the Add/Edit/Delete/MoveUp/MoveDown buttons with > > once created programatically using the KPushButton(const KGuiItem &, ..) > > ctor, by using KStandardGuiItem::add() and KStandardGuiItem::del() and also > > setting icons arrow-up/arrow-down for MoveUp/MoveDown KPushButtons. > > > > 5. Bug tah can be easily fixed: Clicking "Add" and then Cancel should not > > leave empty Section item on the list; the item should be added only after > > accepting the Group Section Dialog. > > > > Friedrich W. H. Kossebau wrote: > At 1.: What advantage does KDialogButtonBox bring that is needed here? > Also adds kdelibs dep, but if that is okay... > At 2.: Hm, how can I create that kind of design? custom formatting? > dialog is from where? > At 3.: Ok > At 4.: Ok > At 5.: If it can be easily fixed, go ahead :P Ok, will see. Another issue > is that the buttons are always enabled, even without items existing/selected. > > Jarosław Staniek wrote: > Cool. > At 1: We use kdelibs anyway in every tiny bit by using KDialog anyway, > and KDialogButtonBox is used there too. In this very case it's just > consistency > At 2: you insert a QCheckBox and separate QLabel; you can also set buddy > to the checkbox for the label > At 5: Are you interested in fixing these bugs too?
KStandardGuiItem::add() does not have the trailing dots after the "Add", so used a custom string. And having just one KStandardGuiItem looked strange, so for consistency I made that one a custom string+button as well. (Looking at the existing KStandardGuiItem, there could be really more, e.g. MoveUp and MoveDown. But as others I ignore that for now, somebody would need to run some statistics tool to gather the really standard ones) - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108096/#review24521 ----------------------------------------------------------- On Jan. 6, 2013, 1:24 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108096/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2013, 1:24 a.m.) > > > Review request for Calligra, Jarosław Staniek and Adam Pigg. > > > Description > ------- > > Reworked KoReport section editor dialogs, especially Ok/Cancel/Close dialog > buttons. Oh, and now also these: > > * base on KDialog > * put labels in front of QCheckboxes > * follow KDE UI guidelines for all text strings > * disable buttons when no-ops > * only offer columns for section grouping which are not used yet > * do not leave an empty group on clicking Cancel during process of adding a > new section group > * skip empty field/key when offering fields for grouping > * make API of ReportSectionDetail consistent (GroupSection where just Section > was used) > * removed any manually set spacings/margins, besides the 0 margins, looks > less strange now > > Better now? :) > > And okay to backport to 2.6, without the string changes? > > > Diffs > ----- > > libs/koreport/wrtembed/detailgroupsectiondialog.h df5504e > libs/koreport/wrtembed/detailgroupsectiondialog.cpp ec0c84c > libs/koreport/wrtembed/detailgroupsectiondialog.ui 32f4700 > libs/koreport/wrtembed/reportsectiondetail.h 3079d5a > libs/koreport/wrtembed/reportsectiondetail.cpp 20b894e > libs/koreport/wrtembed/reportsectiondetailgroup.h 94cebf4 > libs/koreport/wrtembed/sectioneditor.h 97a20c6 > libs/koreport/wrtembed/sectioneditor.cpp e7b9205 > libs/koreport/wrtembed/sectioneditor.ui ba9a337 > plan/libs/ui/reports/reportview.cpp dee77a6 > > Diff: http://git.reviewboard.kde.org/r/108096/diff/ > > > Testing > ------- > > Used in Kexi, works better as before. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
