Re: Review Request: Implement triple button widget

2012-12-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23743 --- I've tested it with Kexi. Does its job quite nice already. Apar

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 20:14, Boudewijn Rempt wrote: > On Wed, 19 Dec 2012, Jaroslaw Staniek wrote: > >> I propose to move to QAbstractMessageHandler. I use this pattern in >> Kexi as well. > > > Well, this is kdelibs stuff -- not our own messageboxes, but in general, > yes, I think we should activel

Re: a new library

2012-12-19 Thread Boudewijn Rempt
On Wed, 19 Dec 2012, Jaroslaw Staniek wrote: I propose to move to QAbstractMessageHandler. I use this pattern in Kexi as well. Well, this is kdelibs stuff -- not our own messageboxes, but in general, yes, I think we should actively refactor to make sure QAbstractMessageHandler is used. Bou

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 19:21, Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, Inge Wallin wrote: > >> Whatever happens I would be very against "contaminating" koodf with UI stuff. >> :) >> >> I don't know if it's formally defined anywhere, but for me koodf is classes >> that represent var

Re: a new library

2012-12-19 Thread Boudewijn Rempt
On Wednesday 19 December 2012 Dec, Inge Wallin wrote: > Whatever happens I would be very against "contaminating" koodf with UI stuff. > :) > > I don't know if it's formally defined anywhere, but for me koodf is classes > that represent various entities inside an ODF file and classes that help l

Re: a new library

2012-12-19 Thread Inge Wallin
On Wednesday, December 19, 2012 15:10:27 Inge Wallin wrote: > On Wednesday, December 19, 2012 15:01:50 C. Boemann wrote: > > Yes, I don't disagree that this is the goal we want in the end, but I'm > > not willing to spend time implementing that now. It's too huge a task. > > however it would be ni

Re: a new library

2012-12-19 Thread Inge Wallin
On Wednesday, December 19, 2012 14:42:33 Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > > > On 19 December 2012 13:19, C. Boemann wrote: > > > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Stani

Re: a new library

2012-12-19 Thread Inge Wallin
On Wednesday, December 19, 2012 15:01:50 C. Boemann wrote: > On Wednesday 19 December 2012 10:41:42 Inge Wallin wrote: > > On Wednesday, December 19, 2012 01:55:38 C. Boemann wrote: > > > Hi > > > > > > In an attempt to to rework the ui, we have run into a problem: > > > > > > KoCreatePathTool in

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 10:41:42 Inge Wallin wrote: > On Wednesday, December 19, 2012 01:55:38 C. Boemann wrote: > > Hi > > > > In an attempt to to rework the ui, we have run into a problem: > > > > KoCreatePathTool in libs/flake needs some widgets from libs/widgets > > > > however the dep

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 14:42:33 Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > > > On 19 December 2012 13:19, C. Boemann wrote: > > > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek

Re: a new library

2012-12-19 Thread Boudewijn Rempt
On Wednesday 19 December 2012 Dec, C. Boemann wrote: > On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > > On 19 December 2012 13:19, C. Boemann wrote: > > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > >> On 19 December 2012 12:59, C. Boemann wrote: > > >> >

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:40:46 Pierre Stirnweiss wrote: > On Wed, Dec 19, 2012 at 1:19 PM, C. Boemann wrote: > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > > On 19 December 2012 12:59, C. Boemann wrote: > > > > Yes i'm not attached to alpine in any way. I couldn't

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
On Wed, Dec 19, 2012 at 1:19 PM, C. Boemann wrote: > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > On 19 December 2012 12:59, C. Boemann wrote: > > > Yes i'm not attached to alpine in any way. I couldn't come up with a > > > generic name that describes the library very well

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > On 19 December 2012 13:19, C. Boemann wrote: > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > >> On 19 December 2012 12:59, C. Boemann wrote: > >> > Yes i'm not attached to alpine in any way. I couldn't come up w

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 13:19, C. Boemann wrote: > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: >> On 19 December 2012 12:59, C. Boemann wrote: >> > Yes i'm not attached to alpine in any way. I couldn't come up with a >> > generic name that describes the library very well ( and no f

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > On 19 December 2012 12:59, C. Boemann wrote: > > Yes i'm not attached to alpine in any way. I couldn't come up with a > > generic name that describes the library very well ( and no flaketools > > doesn't unless we wan to have many su

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 12:59, C. Boemann wrote: > Yes i'm not attached to alpine in any way. I couldn't come up with a generic > name that describes the library very well ( and no flaketools doesn't unless > we > wan to have many such similarly named libraries) and so when i wrote the mail > that w

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 11:36:36 Jaroslaw Staniek wrote: > On 19 December 2012 10:41, Inge Wallin wrote: > > All this said, I think a refactor could be a good idea. But why not make > > a meaningful name? libflaketools should be obvious enough; alpine is > > justa bit too clever for me. >

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 10:03:24 Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > Hi > > > > In an attempt to to rework the ui, we have run into a problem: > > > > KoCreatePathTool in libs/flake needs some widgets from libs/widgets > > > > however the depen

Re: Review Request: Set cover image for ebooks in Author

2012-12-19 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107800/ --- (Updated Dec. 19, 2012, 11 a.m.) Review request for Calligra. Changes --

Re: Review Request: Move ElapsedTime class to a private header that wont be installed

2012-12-19 Thread Philip Hoof
> On Dec. 14, 2012, 4:33 p.m., Marijn Kruisselbrink wrote: > > LGTM When commtting please use this patch, to avoid conflict on my local branch, using git am (not patch -p1 < etc.diff): http://mail.kde.org/pipermail/calligra-devel/attachments/20121214/1a18be63/attachment.patch - Philip

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 10:41, Inge Wallin wrote: > All this said, I think a refactor could be a good idea. But why not make a > meaningful name? libflaketools should be obvious enough; alpine is justa bit > too clever for me. +1 for any obvious name please note the case of libprison - a barcode l

Re: a new library

2012-12-19 Thread Jaroslaw Staniek
On 19 December 2012 10:03, Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > >> Hi > >> > >> In an attempt to to rework the ui, we have run into a problem: > >> > >> KoCreatePathTool in libs/flake needs some widgets from libs/widgets > >> > >> however the dependency i

Re: a new library

2012-12-19 Thread Pierre Stirnweiss
On Wed, Dec 19, 2012 at 10:03 AM, Boudewijn Rempt wrote: > ** > > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > > Hi > > > > > > In an attempt to to rework the ui, we have run into a problem: > > > > > > KoCreatePathTool in libs/flake needs some widgets from libs/widgets > > > > > > ho

Re: a new library

2012-12-19 Thread Inge Wallin
On Wednesday, December 19, 2012 01:55:38 C. Boemann wrote: > Hi > > In an attempt to to rework the ui, we have run into a problem: > > KoCreatePathTool in libs/flake needs some widgets from libs/widgets > > however the dependency is in the opposite direction > > So unless we want to move the to

Re: a new library

2012-12-19 Thread Boudewijn Rempt
On Wednesday 19 December 2012 Dec, C. Boemann wrote: > Hi > > In an attempt to to rework the ui, we have run into a problem: > > KoCreatePathTool in libs/flake needs some widgets from libs/widgets > > however the dependency is in the opposite direction > > So unless we want to move the tools in