Re: Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread Philip Hoof
> On Dec. 4, 2012, 3:51 p.m., Inge Wallin wrote: > > While the patch itself looks fine I would be much more comfortable with an > > exported class that didn't have implementations in the .h file. That's the > > opposite of binary forward compatibility. > > > > But for now and to reduce the wa

Review Request: add d-pointer for KexiScrollView

2012-12-04 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107598/ --- Review request for Calligra and Jarosław Staniek. Description --- add

Review Request: add d-pointer for KexiProjectSelectorWidget

2012-12-04 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107597/ --- Review request for Calligra and Jarosław Staniek. Description --- Thi

Re: Review Request: adding d-pointer for kexidbconnectionwidget

2012-12-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107579/#review22998 --- This review has been submitted with commit 7a01f132fe97949bde8

Re: Review Request: adding d-pointer for kexidbconnectionwidget

2012-12-04 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107579/#review22996 --- Ship it! Good work, but kexicharencodingcombobox.* files added

Re: Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-04 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107578/#review22995 --- Ship it! Good work. Just one thing to fix, then I'll commit.

Re: Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread Boudewijn Rempt
> On Dec. 4, 2012, 3:51 p.m., Inge Wallin wrote: > > While the patch itself looks fine I would be much more comfortable with an > > exported class that didn't have implementations in the .h file. That's the > > opposite of binary forward compatibility. > > > > But for now and to reduce the wa

Re: Unsupported attributes of QGraphicsWidget of CanvasItem in sheets/part

2012-12-04 Thread Boudewijn Rempt
On Tuesday 04 December 2012 Dec, Philip Van Hoof wrote: > The CanvasItem in sheets/part spews these warnings when used in a > QGraphicsScene. > > QGraphicsWidget::setAttribute: unsupported attribute 5 > QGraphicsWidget::setAttribute: unsupported attribute 14 > > Looks like those correspond to >

Re: Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/#review22980 --- Ship it! While the patch itself looks fine I would be much mor

we urgently need more tasks for Google Code-in

2012-12-04 Thread Lydia Pintscher
Heya folks :) Here's a chance to get a lot of work done by our eager Google Code-in students. Google Code-in has been running for a bit now and we're close to running out of tasks. Please help me out by adding new tasks for the students. They're 13 to 17 years old and can work on: * Code * Docume

Re: Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/#review22979 --- Ship it! Ship It! - C. Boemann On Dec. 4, 2012, 2:47 p.m.,

Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread Philip Hoof
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/ --- Review request for Calligra and Boudewijn Rempt. Description --- This

Unsupported attributes of QGraphicsWidget of CanvasItem in sheets/part

2012-12-04 Thread Philip Van Hoof
The CanvasItem in sheets/part spews these warnings when used in a QGraphicsScene. QGraphicsWidget::setAttribute: unsupported attribute 5 QGraphicsWidget::setAttribute: unsupported attribute 14 Looks like those correspond to Qt::WA_StaticContents 5 Indicates that the widget contents are north-we

Re: Review Request: adding d-pointer for kexidbconnectionwidget

2012-12-04 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107579/ --- (Updated Dec. 4, 2012, 1:54 p.m.) Review request for Calligra and Jarosław

Review Request: adding d-pointer for kexidbconnectionwidget

2012-12-04 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107579/ --- Review request for Calligra and Jarosław Staniek. Description --- add

Review Request: adding d-pointer for kexicharencodingcombobox

2012-12-04 Thread Shou Ya
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107578/ --- Review request for Calligra and Jarosław Staniek. Description --- Jus

Re: [GCI] Kexi d-pointer task: needing a KDE identity to commit my work

2012-12-04 Thread Shou Ya
On Tue, Dec 4, 2012 at 6:46 PM, Sune Vuorela wrote: > On 2012-12-04, Shou Ya wrote: >>> OK, I am on IRC #kexi (freenode) mainly on the evenings CET; and >>> tomorrow most of the day. >> Unfortunately I can't use IRC, because the outgoing traffic of our >> school network will be limited at port 80

Re: [GCI] Kexi d-pointer task: needing a KDE identity to commit my work

2012-12-04 Thread Sune Vuorela
On 2012-12-04, Shou Ya wrote: >> OK, I am on IRC #kexi (freenode) mainly on the evenings CET; and >> tomorrow most of the day. > Unfortunately I can't use IRC, because the outgoing traffic of our > school network will be limited at port 80 and 443 only. on http://webchat.freenode.net you have a w

Re: [GCI] Kexi d-pointer task: needing a KDE identity to commit my work

2012-12-04 Thread Shou Ya
On Tue, Dec 4, 2012 at 4:50 PM, Jaroslaw Staniek wrote: > On 4 December 2012 07:39, Shou Ya wrote: >> Hi, >> >> I am working now on the task about adding d-pointers to Kexi, from >> Google >> Code-In(https://www.google-melange.com/gci/task/view/google/gci2012/7971213), >> yet I don't know where

Re: [GCI] Kexi d-pointer task: needing a KDE identity to commit my work

2012-12-04 Thread Jaroslaw Staniek
On 4 December 2012 07:39, Shou Ya wrote: > Hi, > > I am working now on the task about adding d-pointers to Kexi, from > Google > Code-In(https://www.google-melange.com/gci/task/view/google/gci2012/7971213), > yet I don't know where I shall submit my work. > > I don't have a KDE identity so I can'

Re: Review Request: Implement triple button widget

2012-12-04 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 4, 2012, 8:45 a.m.) Review request for Calligra and C. Boema

Re: New PACKAGERS_BUILD option for building Calligra

2012-12-04 Thread Boudewijn Rempt
On Tuesday 04 December 2012 Dec, Dmitry Kazakov wrote: > Cons: > 1) Currently the code depends on Vc's 'staging' branch, so it can't be put > in master. For now all the changes are kept in > 'vector_compositioning_kazakov' branch. Is there any estimated time of arrival for staging to get to Vc ma