> On Dec. 4, 2012, 3:51 p.m., Inge Wallin wrote: > > While the patch itself looks fine I would be much more comfortable with an > > exported class that didn't have implementations in the .h file. That's the > > opposite of binary forward compatibility. > > > > But for now and to reduce the warnings, it's fine. > > Boudewijn Rempt wrote: > Yeah, i think you're right. The change itself is fine of course, but lets > do this proper and get that elapsed time class out of Global.h. It doesn't > belong there at all.
I'll look into it and propose a new review once I'm finished with mving the ElapsedTime class to a non-installed _p.h file and/or into the .cpp file in case there is only one user of it. - Philip ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/#review22980 ----------------------------------------------------------- On Dec. 4, 2012, 2:47 p.m., Philip Hoof wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107580/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2012, 2:47 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > This patch makes Global.h of sheets/ stop using old-style casts, avoiding a > compiler warning for projects using Calligra's sheets component. > > > Diffs > ----- > > sheets/Global.h 1759095 > > Diff: http://git.reviewboard.kde.org/r/107580/diff/ > > > Testing > ------- > > > Thanks, > > Philip Hoof > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
