----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107578/#review22995 -----------------------------------------------------------
Ship it! Good work. Just one thing to fix, then I'll commit. kexi/widget/kexicharencodingcombobox.cpp <http://git.reviewboard.kde.org/r/107578/#comment17556> Please always put implementation of Private right after declaration, in this case in line 37. - Jarosław Staniek On Dec. 4, 2012, 1:51 p.m., Shou Ya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107578/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2012, 1:51 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > Just adding d-pointer for kexicharencodingcombobox. > > > Diffs > ----- > > kexi/widget/kexicharencodingcombobox.h 74fdfb2 > kexi/widget/kexicharencodingcombobox.cpp 4be3315 > > Diff: http://git.reviewboard.kde.org/r/107578/diff/ > > > Testing > ------- > > > Thanks, > > Shou Ya > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
