Re: Review Request: Bibliography database UI

2012-06-13 Thread Jaroslaw Staniek
I didn't read the code, but do you use kexidb for the db creation and data access? I'm asking because of reuse principle. I can help with that for 2.6. On 14/06/2012, Gopalakrishna Bhat wrote: > > >> On June 13, 2012, 9:50 p.m., C. Boemann wrote: >> > i've not tested it either, but to me it sound

Re: Review Request: Bibliography database UI

2012-06-13 Thread Gopalakrishna Bhat
> On June 13, 2012, 9:50 p.m., C. Boemann wrote: > > i've not tested it either, but to me it sounds like it's 'just' the basic > > database ui. We still miss any kind of connection to engines. Therefore I > > wonder if it has any values to users right now? And if not then I don't > > think we

Re: Review Request: improvements in chartshape

2012-06-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105230/#review14714 --- Ship it! I see a few coding style issues, but eventhough plugi

Re: Review Request: Move creation of print dialog to KoView

2012-06-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105225/#review14715 --- Ship it! okay i don't hear anyone else object or have good cou

Re: Review Request: improvements in chartshape

2012-06-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105230/#review14713 --- I asked Brijesh to submit a reequest as per our new safer commi

Re: Review Request: Bibliography database UI

2012-06-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review14710 --- i've not tested it either, but to me it sounds like it's 'just'

Last call for Randa 2012 registration

2012-06-13 Thread Mario Fux
Good morning guys If you plan to come to Randa this September please add yourself asap to s.k.o [1]. Last possibility to add yourself is Saturday, 16th of June till 23:59 UTC. Then we send the budget to the KDE e.V. board. So if you add yourself after this date you need to pay the travel and a

Re: Review Request: Bibliography database UI

2012-06-13 Thread Gopalakrishna Bhat
> On June 13, 2012, 5:44 p.m., Gopalakrishna Bhat wrote: > > plugins/textshape/dialogs/EditFiltersDialog.cpp, line 132 > > > > > > I do not see that u use m_filters anywhere other than the constructor. > > Hence th

Re: Review Request: Bibliography database UI

2012-06-13 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/#review14699 --- I have not tried out this patch. Will try out this weekend. The

Re: Review Request: New integration design to connection tool

2012-06-13 Thread Yue Liu
> On June 13, 2012, 11:35 a.m., Thorsten Zachmann wrote: > > I have some strange behaviours with your patch: > > o When I load the file http://www.zagge.de/files/6_Slides.odp and go to > > page e.g. 5 and activate the connection tool not all connections poits of > > every shape is shown. Theref

Re: Review Request: New integration design to connection tool

2012-06-13 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105237/ --- (Updated June 13, 2012, 2:08 p.m.) Review request for Calligra. Descript

Review Request: Bibliography database UI

2012-06-13 Thread Smit Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105240/ --- Review request for Calligra. Description --- Bibliography database UI

Re: Review Request: New integration design to connection tool

2012-06-13 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105237/#review14696 --- I have some strange behaviours with your patch: o When I load t

Re: Review Request: New integration design to connection tool

2012-06-13 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105237/ --- (Updated June 13, 2012, 10:32 a.m.) Review request for Calligra. Descrip

Review Request: New integration design to connection tool

2012-06-13 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105237/ --- Review request for Calligra. Description --- The original design to c

Re: Review Request: Slightly improve the option widget of the document background tool

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105153/#review14693 --- This review has been submitted with commit c092dc352ed9a98ef6e

Re: Review Request: Set limit to 255 for Text type in MySQL Driver

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105182/#review14695 --- This review has been submitted with commit bb65aa5fe7cc9121b04

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage & Flow

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105180/#review14691 --- This review has been submitted with commit 7010a78b8673037d995

Re: Review Request: make UI texts for exporting Kexi reports more consistent (and solve Kexi i18n TODOs for 2.5)

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105164/#review14694 --- This review has been submitted with commit 162240ab53691b8ffac

Re: Review Request: Implemented KexiDBDatePicker

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105179/#review14689 --- This review has been submitted with commit 30cd84b32e196fdb405

Re: Review Request: Change Stage and Flow to have infinite type canvas

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104928/#review14687 --- This review has been submitted with commit 5fb1fdc8497f1e56ea8

Re: Review Request: Remove some deprecated calls and fix a typing error

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103057/#review14690 --- This review has been submitted with commit fa2dae5e95c32abef7b

Re: Review Request: Increase indent on a list item increases the displayed depth of the list i.e 1 becomes 1.1

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105198/#review14692 --- This review has been submitted with commit 4ab197e7cec1cebc038

Re: Review Request: Kexi MainWindow fullscreen feature.

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105105/#review14684 --- This review has been submitted with commit c2b2b1ec1c08613ba93

Re: Review Request: sync default line markers with LibreOffice 3.5 ones, i.e. add UML line ends

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104560/#review14686 --- This review has been submitted with commit 14ef16ad1b8db279206

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103538/#review14688 --- This review has been submitted with commit 977b4f4ee768f78a879

Re: Review Request: KexiDB: Remove limits for Text data type, leave as option

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105161/#review14681 --- This review has been submitted with commit 23a73bd2190c2cab44c

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14683 --- This review has been submitted with commit c6b51b8f6a2f10269d2

Re: Review Request: Let's use draw:opacity instead of draw:transparency.

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105025/#review14685 --- This review has been submitted with commit ec44da6ed9df3bb861d

Re: Review Request: PDF export: Use view to get page layout

2012-06-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105168/#review14682 --- This review has been submitted with commit 62386efb247fd45a8f2