----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105225/#review14715 -----------------------------------------------------------
Ship it! okay i don't hear anyone else object or have good counter-ideas - so let's ship it. Though I reserve the right to say "I told you so" ;) - C. Boemann On June 12, 2012, 8:35 a.m., Dag Andersen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105225/ > ----------------------------------------------------------- > > (Updated June 12, 2012, 8:35 a.m.) > > > Review request for Calligra. > > > Description > ------- > > View centric apps (plan, sheets) need better control of the print dialog than > what is possible today. > This patch moves the creation of QPrintDialog into a virtual method in KoView > to enable apps to access it or create their own dialog. > > > Diffs > ----- > > libs/main/KoMainWindow.cpp 6720a95 > libs/main/KoView.h ba46c02 > libs/main/KoView.cpp af3aba8 > > Diff: http://git.reviewboard.kde.org/r/105225/diff/ > > > Testing > ------- > > Printing still works with words > > > Thanks, > > Dag Andersen > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel