----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105237/#review14696 -----------------------------------------------------------
I have some strange behaviours with your patch: o When I load the file http://www.zagge.de/files/6_Slides.odp and go to page e.g. 5 and activate the connection tool not all connections poits of every shape is shown. Therefore it is not possible to start a connection from these point. I can however end the connection at those points. o When clicking onto a connection I have the possibility to move the points where this connection is connected. However after that there seems to be no way back to create a new connection. o When creating a new connection and after I started dragging from the first connection point in the odp given above I get very stange jumping of the connection to someplace where my cursor is not during dragging. - Thorsten Zachmann On June 13, 2012, 10:32 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105237/ > ----------------------------------------------------------- > > (Updated June 13, 2012, 10:32 a.m.) > > > Review request for Calligra. > > > Description > ------- > > The original design to connection tool used several edit mode to manipulate > connections and connection points, it works but user may not find out how to > use it easily, so I added an option widget providing tool buttons to the > usual actions user might want to use when manipulating connections, and > disabled the double click to change edit mode feature in case user may > accidentally enter unintended edit modes. > > Other improvements are, > double click blank region to back to default tool, so now connection tool is > consistent with path tool in this behavior, > added text box to new connectors created by default. > > > Diffs > ----- > > libs/flake/KoConnectionShape.h 37984022f0154696d47385c5119f559978f9d9f2 > pics/oxygen/ox16-action-curve-connector.png PRE-CREATION > pics/oxygen/ox16-action-lines-connector.png PRE-CREATION > pics/oxygen/ox16-action-standard-connector.png PRE-CREATION > pics/oxygen/ox16-action-straight-connector.png PRE-CREATION > plugins/defaultTools/CMakeLists.txt > 1f160106067dddba0d1ec0390669d31f66caf270 > plugins/defaultTools/connectionTool/ConnectionEditModeWidget.h PRE-CREATION > plugins/defaultTools/connectionTool/ConnectionEditModeWidget.cpp > PRE-CREATION > plugins/defaultTools/connectionTool/ConnectionTool.h > 172eb7fd919b22ee60d2c3a594f09bebed43eea8 > plugins/defaultTools/connectionTool/ConnectionTool.cpp > d95a34f02850719b13c7acbf5f57381fd53c6908 > > Diff: http://git.reviewboard.kde.org/r/105237/diff/ > > > Testing > ------- > > Tested in every application. connector path update not work in Words, but I > think that's irrelevant with my patch. > > > Thanks, > > Yue Liu > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
