Re: Review Request: Fix regression of group shape size

2011-09-16 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/#review6579 --- Ship it! Checked it as well, and all is fine, so please commit.

Re: Review Request: Fix regression of group shape size

2011-09-16 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/ --- (Updated Sept. 16, 2011, 4:52 p.m.) Review request for Calligra. Changes

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-16 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/#review6578 --- Ship it! I have nothing more to complain about. So if ctester a

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-16 Thread Jan Hambrecht
> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeRegistry.cpp, line 169 > > > > > > Excessive whitespace, please remove. > > Inge Wallin wrote: > This is getting into the zander domai

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-16 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/ --- (Updated Sept. 16, 2011, 4:15 p.m.) Review request for Calligra. Changes

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-16 Thread Inge Wallin
> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeRegistry.cpp, line 169 > > > > > > Excessive whitespace, please remove. > > Inge Wallin wrote: > This is getting into the zander domai

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-16 Thread Jan Hambrecht
> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeRegistry.cpp, line 169 > > > > > > Excessive whitespace, please remove. > > Inge Wallin wrote: > This is getting into the zander domai

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-16 Thread Inge Wallin
> On Sept. 16, 2011, 12:33 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeRegistry.cpp, lines 162-168 > > > > > > I am not sure the logic explained here is what we want. There might be > > another shape which can

Re: Review Request: Fix regression of group shape size

2011-09-16 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/#review6570 --- I'd support this change. Even if shapegroup is just a logical gr

Re: Review Request: Fix regression of group shape size

2011-09-16 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/#review6569 --- Have you checked whether this breaks Krita? I seem to remember w

Re: Review Request: Add frame preview support (aka PNG/SVG Previews)

2011-09-16 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102512/#review6566 --- libs/flake/KoShapeRegistry.cpp

Re: Review Request: Enable search from cursor position in the backend

2011-09-16 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102617/#review6565 --- Ship it! As discussed on IRC. - Arjen On Sept. 16, 2011, 10:

Re: Review Request: Enable search from cursor position in the backend

2011-09-16 Thread Arjen Hiemstra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102617/#review6564 --- Ship it! As discussed on IRC. - Arjen On Sept. 16, 2011, 10:

Re: Review Request: Create text box when double click in default tool

2011-09-16 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102629/#review6563 --- I would suggest adding such application specific code to your ap

Review Request: Fix regression of group shape size

2011-09-16 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102633/ --- Review request for Calligra. Summary --- There was a regression intro

Re: Review Request: Create text box when double click in default tool

2011-09-16 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102629/#review6553 --- plugins/defaultTools/defaulttool/DefaultTool.cpp

Re: Review Request: Enable search from cursor position in the backend

2011-09-16 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102617/ --- (Updated Sept. 16, 2011, 10:08 a.m.) Review request for Calligra. Change

Re: Review Request: Create text box when double click in default tool

2011-09-16 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102629/#review6550 --- hmm, so doubleclicking on a textshape, pictureshape,pathshape,v

Review Request: Create text box when double click in default tool

2011-09-16 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102629/ --- Review request for Calligra. Summary --- Changed double click behavio