-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102633/#review6579
-----------------------------------------------------------

Ship it!


Checked it as well, and all is fine, so please commit.

- Boudewijn


On Sept. 16, 2011, 4:52 p.m., Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102633/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 4:52 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Summary
> -------
> 
> There was a regression introduced that made the group shape always returning 
> a zero size. This broke the filter effect on group shape feature.
> 
> 
> Diffs
> -----
> 
>   krita/ui/flake/kis_shape_layer.cc 58c4812 
>   krita/ui/flake/kis_shape_selection.cpp 5d77d7c 
>   libs/flake/KoShapeGroup.cpp aa8c1f3 
>   libs/flake/SimpleShapeContainerModel.h deee6a9 
>   libs/flake/tests/TestShapeContainer.cpp 5f51c9c 
> 
> Diff: http://git.reviewboard.kde.org/r/102633/diff
> 
> 
> Testing
> -------
> 
> Additional test in krita with file from bug 227512.
> 
> 
> Thanks,
> 
> Jan
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to