Re: Review Request: Make it possible to get a all draw styles of a defined type.

2011-09-10 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/ --- (Updated Sept. 11, 2011, 4:49 a.m.) Review request for Calligra. Changes

Re: Review Request: Add support to fo:clip property in pictureshape

2011-09-10 Thread Thorsten Zachmann
> On Sept. 10, 2011, 6:19 p.m., Casper Boemann wrote: > > plugins/pictureshape/PictureShape.cpp, line 299 > > > > > > value can also be clipshape.. I don't see any code that handles that ? The only allowed clipshap

Re: Review Request: Add support to fo:clip property in pictureshape

2011-09-10 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102570/#review6410 --- The fo:clip is a property of the style:graphic-property and can

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-10 Thread Thorsten Zachmann
> On Sept. 9, 2011, 3:25 a.m., Thorsten Zachmann wrote: > > libs/odf/KoOdfStylesReader.cpp, lines 289-305 > > > > > > That part is only called when a style is added which only happens a > > notes-configuration is f

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-10 Thread Brijesh Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 10, 2011, 8:49 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-10 Thread Brijesh Patel
> On Sept. 9, 2011, 3:25 a.m., Thorsten Zachmann wrote: > > libs/odf/KoOdfStylesReader.cpp, lines 289-305 > > > > > > That part is only called when a style is added which only happens a > > notes-configuration is f

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-10 Thread Brijesh Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 10, 2011, 8:43 p.m.) Review request for Calligra. Changes

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-10 Thread Brijesh Patel
> On Sept. 8, 2011, 4:58 a.m., Thorsten Zachmann wrote: > > libs/kotext/KoInlineNote.cpp, line 233 > > > > > > Is there a reason to remove this line here. I think it only makes sure > > that the initial value of th

Re: Features changelog for Calligra 2.4 Beta

2011-09-10 Thread Boudewijn Rempt
On Sunday 04 September 2011 Sep, Cyrille Berger Skott wrote: > Hi, > > The beta is coming soon (not yet tagged), but I would like to start gathering > the features (or super major bug fix) list, so that we don't rush this :) For Krita, we had about 1400 commits during the 2.4 development lifecyc

Re: Review Request: Add support to fo:clip property in pictureshape

2011-09-10 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102570/#review6395 --- plugins/pictureshape/PictureShape.cpp

Re: Review Request: Add support to fo:clip property in pictureshape

2011-09-10 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102570/#review6394 --- I'm a bit catious about your pt to pixel conversions. let's inve

Review Request: Add support to fo:clip property in pictureshape

2011-09-10 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102570/ --- Review request for Calligra. Summary --- Adds support to fo:clip ODF

Re: Review Request: Make it possible to get a all draw styles of a defined type.

2011-09-10 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/#review6371 --- libs/odf/KoOdfStylesReader.h

Re: Review Request: Make it possible to get a all draw styles of a defined type.

2011-09-10 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102562/#review6370 --- I think in general it looks okay, and would press ship it if i f