Re: Review Request: Send progress updates more frequently

2011-01-31 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100438/#review1136 --- libs/main/KoUpdater.cpp

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-01-31 Thread Jaroslaw Staniek
ok.. small hint; by coincidence I've encountered KEXI_DATAAWAREOBJECTINTERFACE code in kexi/widget/tableview/kexidataawareobjectiface.h. It'a a Q_OBJECT-like macro that inserts connecting methods to a class. Maybe similar macro could be useful in this case. 2011/2/1 Mani N C > My bad, I agree w

Re: review-request: Calligra Words performance work

2011-01-31 Thread Thorsten Zachmann
Hello Sebastian, On Monday, January 31, 2011 17:00:55 Sebastian Sauer wrote: > Hi *, > > please find attached[1] a patch (diff between master and the > words-layout_performance-sebsauer branch) that improves > layouting-performance of Calligra Words. > void KWTextFrameSet::requestMoreFrames(qr

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-01-31 Thread Mani N C
My bad, I agree we won't be able to connect signals. The problem I have is when f-office is compiled out-of-tree the gives errors. I am trying to fix this in such a way that it would compile in-source and out-of-tree. Thanks for your comments, I will try to emit pure virtual methods and see. Br, M

Re: Review Request: Send progress updates more frequently

2011-01-31 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100438/ --- (Updated Feb. 1, 2011, 4:01 a.m.) Review request for Calligra. Changes -

Calligra Sprint budget approved

2011-01-31 Thread Thorsten Zachmann
Hello all, I'm pleased to inform you that the KDE e.V. board has approved our budget for the KDE sprint. So please everybody go on and order your tickets as soon as possible. Also please update the wiki page with the amount the ticket costs and the time you are arriving/leaving. With the help

Re: Git policy: git merge or git cherry-pick

2011-01-31 Thread jaham
On Monday 31 January 2011 14:27:50 Lukast dev wrote: > Hello, > > I would like to have your opinion about the preferable and consistent way > of merging of the code from the features branches we have into master. > > There are more ways: > 1. git cherry-picking > a) cherrypick single commits > b)

Re: Qt 4.7 as minimal requirement ?

2011-01-31 Thread jaham
On Monday 31 January 2011 17:57:17 Cyrille Berger Skott wrote: > Hi, > > I am asking the question since right now there is a compilation error for > Qt 4.6 and the connectiontool: > > /home/cyrille/src/calligra/plugins/defaultTools/connectionTool/ConnectionTo > ol.cpp: In member function ‘virtual

Re: Qt 4.7 as minimal requirement ?

2011-01-31 Thread Jaroslaw Staniek
On 31 January 2011 21:12, Cyrille Berger Skott wrote: > On Monday 31 January 2011, Jaroslaw Staniek wrote: >> As we can remember, this happens again, this time for Words. Before it >> was for Krita. >> While I understand the choice is uneasy, I recommend ifdefs and >> informative warnings... >> An

Re: Qt 4.7 as minimal requirement ?

2011-01-31 Thread Cyrille Berger Skott
On Monday 31 January 2011, Jaroslaw Staniek wrote: > As we can remember, this happens again, this time for Words. Before it > was for Krita. > While I understand the choice is uneasy, I recommend ifdefs and > informative warnings... > And maybe an update in README.PACKAGERS... I don't see it as a b

Re: Git policy: git merge or git cherry-pick

2011-01-31 Thread Cyrille Berger Skott
On Monday 31 January 2011, Dmitry Kazakov wrote: > On Mon, Jan 31, 2011 at 4:27 PM, Lukast dev <> wrote: > > boud: > ... > > > o but then the development branch should never be deleted, otherwise > > we have one big commit that nobody can every bisect anymore and never > > figure out the history o

Re: Qt 4.7 as minimal requirement ?

2011-01-31 Thread Boudewijn Rempt
On Monday 31 January 2011, Cyrille Berger Skott wrote: > Hi, > > I am asking the question since right now there is a compilation error for Qt > 4.6 and the connectiontool: > > /home/cyrille/src/calligra/plugins/defaultTools/connectionTool/ConnectionTool.cpp: > > In member function ‘virtual voi

Re: Qt 4.7 as minimal requirement ?

2011-01-31 Thread Jaroslaw Staniek
On 31 January 2011 17:57, Cyrille Berger Skott wrote: > Hi, > > I am asking the question since right now there is a compilation error for Qt > 4.6 and the connectiontool: > > /home/cyrille/src/calligra/plugins/defaultTools/connectionTool/ConnectionTool.cpp: > In member function ‘virtual void > Con

Qt 4.7 as minimal requirement ?

2011-01-31 Thread Cyrille Berger Skott
Hi, I am asking the question since right now there is a compilation error for Qt 4.6 and the connectiontool: /home/cyrille/src/calligra/plugins/defaultTools/connectionTool/ConnectionTool.cpp: In member function ‘virtual void ConnectionTool::mouseMoveEvent(KoPointerEvent*)’: /home/cyrille/src/

review-request: Calligra Words performance work

2011-01-31 Thread Sebastian Sauer
Hi *, please find attached[1] a patch (diff between master and the words-layout_performance-sebsauer branch) that improves layouting-performance of Calligra Words. This is done by getting right of the eventloop-reentry that happened quit a lot before during layouting [2]. This is the change done

Re: Git policy: git merge or git cherry-pick

2011-01-31 Thread Dmitry Kazakov
On Mon, Jan 31, 2011 at 4:27 PM, Lukast dev <> wrote: > > boud: > ... > o but then the development branch should never be deleted, otherwise > we have one big commit that nobody can every bisect anymore and never > figure out the history of > I'm not sure the latest statement is true. If the bra

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-01-31 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100462/#review1134 --- One of the solutions is to have emit*() pure virtual methods in

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-01-31 Thread Jarosław Staniek
> On Jan. 31, 2011, 1:34 p.m., Jarosław Staniek wrote: > > I wonder what happens if you move the signals. It will be not possible to > > connect to them in KoAbstractApplicationController code since > > KoAbstractApplicationController cannot inherit QObject. The hack with > > including .moc fi

Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-01-31 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100462/#review1132 --- I wonder what happens if you move the signals. It will be not po

Git policy: git merge or git cherry-pick

2011-01-31 Thread Lukast dev
Hello, I would like to have your opinion about the preferable and consistent way of merging of the code from the features branches we have into master. There are more ways: 1. git cherry-picking a) cherrypick single commits b) produce one squashed patch for master and commit it 2. git merge We

Re: Review Request: Send progress updates more frequently

2011-01-31 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100438/#review1131 --- Okay, I looked at it good and hard. The patch is actually ok, an

Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-01-31 Thread Mani Chandrasekar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100462/ --- Review request for Calligra. Summary --- This patch removes KoAbstrac