----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100438/#review1131 -----------------------------------------------------------
Okay, I looked at it good and hard. The patch is actually ok, and doesn't harm the gui update throttling (I had forgotten I had implemented that in a different way). However, the call to addPoint() should definitely be made option, for instance by adding a parameter to KoProgressUpdater's constructor that enables profiling, or an environment settings. It's useless to store all these timepoints when it isn't needed at all, and takes a lot of time, as confirmed by Marijn. - Boudewijn On Jan. 24, 2011, 4:33 a.m., Thorsten Zachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100438/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2011, 4:33 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Send progress updates more frequently. There is already a limitation on what > is send to the user in KoProgressUpdater that only sends updates only every > 0.1 second. Without the change it can happen that the progress is only > reported every 0.4 seconds. With this change the progress bar advances more > smooth and does not jump as without the change > > > Diffs > ----- > > libs/main/KoUpdater.cpp 8ea5fce > libs/main/KoUpdaterPrivate_p.h af82419 > > Diff: http://git.reviewboard.kde.org/r/100438/diff > > > Testing > ------- > > > Thanks, > > Thorsten > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
