Re: Confusing definitions and declarations of mig_dealloc_reply_port()

2015-11-04 Thread Diego Nieto Cid
2015-11-04 16:03 GMT-03:00 Svante Signell : > On Wed, 2015-11-04 at 18:57 +0100, Samuel Thibault wrote: > > Diego Nieto Cid, on Wed 04 Nov 2015 10:50:35 -0300, wrote: > > > assert (__hurd_local_reply_port == arg || arg == MACH_PORT_NULL) > > > > > > AIUI any other values are bogus given how 'mig_

Re: Confusing definitions and declarations of mig_dealloc_reply_port()

2015-11-04 Thread Samuel Thibault
Svante Signell, on Wed 04 Nov 2015 20:03:02 +0100, wrote: > On Wed, 2015-11-04 at 18:57 +0100, Samuel Thibault wrote: > > Diego Nieto Cid, on Wed 04 Nov 2015 10:50:35 -0300, wrote: > > >   assert (__hurd_local_reply_port == arg || arg == MACH_PORT_NULL) > > > > > > AIUI any other values are bogus

Re: Confusing definitions and declarations of mig_dealloc_reply_port()

2015-11-04 Thread Svante Signell
On Wed, 2015-11-04 at 18:57 +0100, Samuel Thibault wrote: > Diego Nieto Cid, on Wed 04 Nov 2015 10:50:35 -0300, wrote: > >   assert (__hurd_local_reply_port == arg || arg == MACH_PORT_NULL) > > > > AIUI any other values are bogus given how 'mig_get_reply_port' and > > 'mig_dealloc_reply_port' are

Re: Confusing definitions and declarations of mig_dealloc_reply_port()

2015-11-04 Thread Samuel Thibault
Diego Nieto Cid, on Wed 04 Nov 2015 10:50:35 -0300, wrote: >   assert (__hurd_local_reply_port == arg || arg == MACH_PORT_NULL) > > AIUI any other values are bogus given how 'mig_get_reply_port' and > 'mig_dealloc_reply_port' are meant to be paired. That's probably a good thing to do, yes. Samue

Re: Confusing definitions and declarations of mig_dealloc_reply_port()

2015-11-04 Thread Diego Nieto Cid
Hi 2015-11-04 6:30 GMT-03:00 Svante Signell : > > Diego, > Cc: bug-hurd. Oh, I mistakenly hit 'Reply'. I hate when that happens :( > On Tue, 2015-11-03 at 15:55 -0300, Diego Nieto Cid wrote: > > > I'd suggest to assert (port == arg || arg == MACH_PORT_NULL) just to > > be sure users don't expect

Re: Confusing definitions and declarations of mig_dealloc_reply_port()

2015-11-04 Thread Svante Signell
Diego, Cc: bug-hurd. On Tue, 2015-11-03 at 15:55 -0300, Diego Nieto Cid wrote: > Hi > > 2015-11-03 9:51 GMT-03:00 Svante Signell : > > > > Hello, > > >  > Definition, declaration and usages are all consistent, they pass and > receive one argument. > The argument being unsed is just an implementat