Re: mingw conflict between mkdtemp and sys_stat

2006-10-31 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/27/2006 9:09 AM: > Eric Blake byu.net> writes: > >> The second half, fixing mkdtemp to use the new tempname module and the >> existing sys_stat module, so that mkdtemp and mkstemp can coexist on >> mingw, still needs Bru

Re: mingw conflict between mkdtemp and sys_stat

2006-10-27 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Also, is it worth changing other modules that depend on stat-macros to > instead depend on sys_stat, and delete the #include "stat-macros.h" line > from their implementation? Sure, but more generally I think it's better to move the stuff into lib/stat_.h,

Re: mingw conflict between mkdtemp and sys_stat

2006-10-27 Thread Eric Blake
Eric Blake byu.net> writes: > The second half, fixing mkdtemp to use the new tempname module and the > existing sys_stat module, so that mkdtemp and mkstemp can coexist on > mingw, still needs Bruno's approval; I'll post that patch later in light > of this commit. And I need mkdtemp fixed before

Re: mingw conflict between mkdtemp and sys_stat

2006-10-27 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 10/17/2006 10:03 PM: > Eric Blake <[EMAIL PROTECTED]> writes: > >> It just looks nicer if we provide gnulib >> modules with exported APIs that do not lie in the reserved namespace. > > Sure, but can't you do something like

Re: mingw conflict between mkdtemp and sys_stat

2006-10-17 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > It just looks nicer if we provide gnulib > modules with exported APIs that do not lie in the reserved namespace. Sure, but can't you do something like the following (taken from mktime.c)? This minimizes the changes from libc and packages it inside "#ifnde

Re: mingw conflict between mkdtemp and sys_stat

2006-10-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 10/14/2006 10:46 PM: > Eric Blake <[EMAIL PROTECTED]> writes: > >> Best of all, this patch deletes more than twice as many lines than what it >> adds >> in new files :) > > I like that part! > > As for mkstemp, there is

Re: mingw conflict between mkdtemp and sys_stat

2006-10-14 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Best of all, this patch deletes more than twice as many lines than what it > adds > in new files :) I like that part! As for mkstemp, there is some desire to keep the sources as close to glibc as possible, with the idea of migrating our fixes back. So,

Re: mingw conflict between mkdtemp and sys_stat

2006-10-13 Thread Eric Blake
Eric Blake byu.net> writes: > > For that matter, it is rather enlightening to compare tmpdir.c/mkdtemp.c > against tempname.c/mkstemp.c - both are based on the same upstream glibc > files. Bruno and Paul, would you be willing to accept a patch that does the > following things? > > - Break t

Re: mingw conflict between mkdtemp and sys_stat

2006-10-13 Thread Eric Blake
Eric Blake byu.net> writes: > > Any chance we can fix the mkdtemp module depend on the sys_stat module, which > already takes care of mkdir for mingw, rather than open-coding its own mkdir > replacement? And would this be any closer to the glibc implementation? For that matter, it is rather

mingw conflict between mkdtemp and sys_stat

2006-10-13 Thread Eric Blake
I found that M4 is now failing to compile on mingw ever since I imported the clean-temp module due to a conflict between modules: gcc -mno-cygwin -DHAVE_CONFIG_H -DSIGNAL_SAFE_LIST -I. -I.. -I../../lib - g2 -Wall -Werror -MT mkdtemp.o -MD -MP -MF .deps/mkdtemp.Tpo -c -o mkdtemp.o ../../lib/m