-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Paul Eggert on 10/14/2006 10:46 PM:
> Eric Blake <[EMAIL PROTECTED]> writes:
>
>> Best of all, this patch deletes more than twice as many lines than what it
>> adds
>> in new files :)
>
> I like that part!
>
> As for mkstemp, there is some desire to keep the sources as close
> to glibc as possible, with the idea of migrating our fixes back.
> So, for example, I'd prefer to avoid changes like this:
>
>> int
>> -mkstemp (template)
>> - char *template;
>> +mkstemp (char *template)
>> {
>
> since glibc (for some weird reason that has never been explained to
> me) prefers K&R style for external function definitions. Also, I
> don't see why __gen_tempname needs to be renamed to gen_tempname.
> Other than that, I don't see a problem for that module.
>
I'll work at a second pass of this patch to be closer to glibc. Would it
be okay if I still provide a weak_alias gen_tempname wrapper around
__gen_tempname on glibc systems? It just looks nicer if we provide gnulib
modules with exported APIs that do not lie in the reserved namespace.
Bruno, is this patch idea acceptable? Without it, combining the mkstemp
and mkdtemp modules fails to compile on mingw, because mkstemp pulls in
the sys_stat module which provides a conflicting mkdir definition.
- --
Life is short - so eat dessert first!
Eric Blake [EMAIL PROTECTED]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFNZEx84KuGfSFAYARAkcJAJ49T99qjeNE7/5pLqxAZUghccbqKQCdHLen
rNZ1/4cUQQPut8ffVyL6uF4=
=LEc0
-----END PGP SIGNATURE-----
