Eric Blake <[EMAIL PROTECTED]> writes:

> Best of all, this patch deletes more than twice as many lines than what it 
> adds 
> in new files :)

I like that part!

As for mkstemp, there is some desire to keep the sources as close
to glibc as possible, with the idea of migrating our fixes back.
So, for example, I'd prefer to avoid changes like this:

>  int
> -mkstemp (template)
> -     char *template;
> +mkstemp (char *template)
>  {

since glibc (for some weird reason that has never been explained to
me) prefers K&R style for external function definitions.  Also, I
don't see why __gen_tempname needs to be renamed to gen_tempname.
Other than that, I don't see a problem for that module.


Reply via email to