Re: [PATCH] maint.mk: new syntax check for HAVE_DECL checks

2012-07-13 Thread Eric Blake
On 07/13/2012 02:15 PM, Jim Meyering wrote: > Eric Blake wrote: >> Based on Karel's report, we might as well enforce a syntax check >> to help avoid future problems. >> https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html >> >> * top/maint.mk (sc_prohibit_undefined_have_decl_tests): N

Re: [PATCH] maint.mk: new syntax check for HAVE_DECL checks

2012-07-13 Thread Jim Meyering
Eric Blake wrote: > Based on Karel's report, we might as well enforce a syntax check > to help avoid future problems. > https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html > > * top/maint.mk (sc_prohibit_undefined_have_decl_tests): New rule. > * cfg.mk > (exclude_file_name_regexp--sc

Re: Reorder a couple of steps in README-release

2012-07-13 Thread Eric Blake
On 07/13/2012 02:00 PM, Jim Meyering wrote: > Reuben Thomas wrote: >> The attached patch simply moves a paragraph so that the step of >> pushing the final (NEWS-updating) commits to git happens before >> uploading any release files. > > Hi Reuben, > > Thanks for the suggestion, but I deliberately

[PATCH] maint.mk: new syntax check for HAVE_DECL checks

2012-07-13 Thread Eric Blake
Based on Karel's report, we might as well enforce a syntax check to help avoid future problems. https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html * top/maint.mk (sc_prohibit_undefined_have_decl_tests): New rule. * cfg.mk (exclude_file_name_regexp--sc_prohibit_undefined_have_decl_t

Re: Reorder a couple of steps in README-release

2012-07-13 Thread Jim Meyering
Reuben Thomas wrote: > The attached patch simply moves a paragraph so that the step of > pushing the final (NEWS-updating) commits to git happens before > uploading any release files. Hi Reuben, Thanks for the suggestion, but I deliberately chose to upload the tarball(s) before pushing the tag an

Re: [PATCHv2] argp: make HAVE_DECL usage consistent

2012-07-13 Thread Eric Blake
On 07/13/2012 01:27 PM, Paul Eggert wrote: > Yes, thanks, that looks good. Okay, pushed. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCHv2] argp: make HAVE_DECL usage consistent

2012-07-13 Thread Paul Eggert
Yes, thanks, that looks good.

Re: request to relax license of 'stat-time'

2012-07-13 Thread Eric Blake
On 07/13/2012 12:34 PM, James Youngman wrote: > Fine for me too, for any officially published issue of the LGPL. Thanks; I'm pushing this. From f74aa2c36b8cf96b5c6de3c25f2e9aed72f3e1d2 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Fri, 13 Jul 2012 12:49:36 -0600 Subject: [PATCH] stat-time: rel

Re: request to relax license of 'stat-time'

2012-07-13 Thread James Youngman
Fine for me too, for any officially published issue of the LGPL.

[PATCHv2] argp: make HAVE_DECL usage consistent

2012-07-13 Thread Eric Blake
Autoconf guarantees that AC_CHECK_DECLS always defines the corresponding HAVE_DECL_*. But our hand-coded use of AC_CHECK_DECL did not define the macro to 0, leading to a false positive complaint: https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html By sticking to conventions, we avoi

Re: [PATCH] argp: fix HAVE_DECL usage error

2012-07-13 Thread Eric Blake
On 07/13/2012 12:04 PM, Paul Eggert wrote: > On 07/13/2012 10:53 AM, Eric Blake wrote: >> Autoconf guarantees that AC_CHECK_DECLS_ONCE always defines the >> corresponding HAVE_DECL_*, so checking #ifndef HAVE_DECL_* is bogus. >> https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html >>

Re: [PATCH] argp: fix HAVE_DECL usage error

2012-07-13 Thread Paul Eggert
On 07/13/2012 10:53 AM, Eric Blake wrote: > Autoconf guarantees that AC_CHECK_DECLS_ONCE always defines the > corresponding HAVE_DECL_*, so checking #ifndef HAVE_DECL_* is bogus. > https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html > > * lib/argp-parse.c (__argp_parse): Check conte

Re: request to relax license of 'stat-time'

2012-07-13 Thread Eric Blake
On 07/10/2012 10:20 AM, Bruno Haible wrote: > Eric Blake wrote: >>> Libvirt would like to use lib/stat-time.h to portably get at nanosecond >>> timestamps from an LGPLv2+ license; but this file is currently licensed >>> LGPLv3+. Any objections to relaxing the license, particularly since >>> POSIX

[PATCH] argp: fix HAVE_DECL usage error

2012-07-13 Thread Eric Blake
Autoconf guarantees that AC_CHECK_DECLS_ONCE always defines the corresponding HAVE_DECL_*, so checking #ifndef HAVE_DECL_* is bogus. https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html * lib/argp-parse.c (__argp_parse): Check contents of HAVE_DECL macros, not whether they are define

[PATCH] strndup: fix m4 usage error

2012-07-13 Thread Eric Blake
Autoconf guarantees that AC_CHECK_DECLS_ONCE always defines the corresponding HAVE_DECL_*, so checking #ifndef HAVE_DECL_* is bogus. https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html * m4/strndup.m4 (gl_FUNC_STRNDUP): HAVE_DECL_STRNDUP is always defined, to either 0 or 1. Reported

Reorder a couple of steps in README-release

2012-07-13 Thread Reuben Thomas
The attached patch simply moves a paragraph so that the step of pushing the final (NEWS-updating) commits to git happens before uploading any release files. >From a53f102b0d7cc8dd8db6a632321ba8b623e56f58 Mon Sep 17 00:00:00 2001 From: Reuben Thomas Date: Fri, 13 Jul 2012 11:56:10 +0100 Subject: [

README-release patch

2012-07-13 Thread Reuben Thomas
I still have the following patch awaiting integration; I believe I fixed everything that was disliked about previous versions (non-ASCII characters &c.), so probably it was just overlooked? >From 0df8b797d2a77fee26f37dfaac7dec3a895a6ebd Mon Sep 17 00:00:00 2001 From: Reuben Thomas Date: Tue, 29 M