On 07/13/2012 10:53 AM, Eric Blake wrote: > Autoconf guarantees that AC_CHECK_DECLS_ONCE always defines the > corresponding HAVE_DECL_*, so checking #ifndef HAVE_DECL_* is bogus. > https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html > > * lib/argp-parse.c (__argp_parse): Check contents of HAVE_DECL > macros, not whether they are defined.
But those HAVE_DECL_ macros are not set by AC_CHECK_DECLS_ONCE. I don't think the change broke anything, but it wasn't needed. That being said, I suggest also changing gl_ARGP so that it sets thos HAVE_DECL_ macros to 0 or 1, rather than to undefined or 1, to be compatible with the usual style in gnulib.
