Re: Move sha1 to C?

Hello, * Paul Eggert wrote on Tue, May 24, 2011 at 07:28:36AM CEST: > Come to think of it, it'd be even easier to read this way: > > sed_extract_condition2=' > /^ *'"$escaped_dep"' *\[.*\] *$/{ > s/^ *'"$escaped_dep"' *\[\(.*\)\] *$/\1/p > } > ' It's even easier to read this wa

Re: Move sha1 to C?

[Dropping emacs-devel as this is really a gnulib thing.] On 05/23/11 22:09, Thien-Thi Nguyen wrote: >+sed_extract_condition2='/^ *'"$escaped_dep"' *\[.*\] *$/{ >+ s/^ *'"$escaped_dep"' *\[\(.*\)\] *$/\1/p >+}' > > IIUC the curly braces

Re: Move sha1 to C?

() Paul Eggert () Mon, 23 May 2011 15:10:47 -0700 +sed_extract_condition1='/^ *'"$escaped_dep"' *$/{ + s/^.*$/true/p +}' +sed_extract_condition2='/^ *'"$escaped_dep"' *\[.*\] *$/{ + s/^ *'"$escaped_de

Re: hash.m4 simplification

Bruno Haible wrote: > And another one: 'hash' depends on 'stdbool', therefore does not need an > additional explicit AM_STDBOOL_H invocation. > > 2011-05-23 Bruno Haible > > hash: Simplify autoconf macro. > * m4/hash.m4 (gl_HASH): Don't require AM_STDBOOL_H. More good clean-up. Than

Re: idcache fix

Bruno Haible wrote: >> 2011-05-23 Bruno Haible >> >> getugroups: Fix module description. >> * modules/getugroups (Include): Set to "getugroups.h". > > Another one of the same kind: > > > 2011-05-23 Bruno Haible > > idcache: Fix module description. > * modules/idcache (In

Re: Move sha1 to C?

On 2011-05-24 06:10 +0800, Paul Eggert wrote: > My guess is that's due to a bit of unportable code in gnulib-tool, > which I just fixed as follows. Could you please try it again? If > that doesn't work, I can push the sha1 gnulib code into the Emacs > trunk myself, but I'd rather get it working f

idcache fix

> 2011-05-23 Bruno Haible > > getugroups: Fix module description. > * modules/getugroups (Include): Set to "getugroups.h". Another one of the same kind: 2011-05-23 Bruno Haible idcache: Fix module description. * modules/idcache (Include): Set to "idcache.h".

Re: Move sha1 to C?

[Adding bug-gnulib to the CC: list.] On 05/23/11 11:14, Leo wrote: > I run gnulib-tool on OSX and get tons of lines such as: > > sed: 1: "/^ *unistd *$/{s/^.*$/t ...": bad flag in substitute command: '}' > ../gnulib/gnulib-tool: line 801: printf: write error: Broken pipe My guess is that's

hash.m4 simplification

And another one: 'hash' depends on 'stdbool', therefore does not need an additional explicit AM_STDBOOL_H invocation. 2011-05-23 Bruno Haible hash: Simplify autoconf macro. * m4/hash.m4 (gl_HASH): Don't require AM_STDBOOL_H. --- m4/hash.m4.orig Mon May 23 23:54:15 2011 ++

getugroups fix

Another trivial fix: Module 'getugroups' is missing a statement about the include file needed to get the functionality. This field is used for documentation purposes. 2011-05-23 Bruno Haible getugroups: Fix module description. * modules/getugroups (Include): Set to "getugroups

Re: [PATCH] strerror_r: enforce POSIX recommendations

On 05/21/2011 12:09 PM, Bruno Haible wrote: > Eric Blake wrote: >> 2011-05-20 Eric Blake >> >> +strerror_r: enforce POSIX recommendations >> +* lib/strerror_r.c (safe_copy): New helper method. >> +(strerror_r): Guarantee a non-empty string. >> +* tests/test-strerror_r.c (main):

Re: [PATCH] strerror_r: avoid compiler warning

On 05/21/2011 12:02 PM, Bruno Haible wrote: > Eric Blake wrote: >> @@ -48,7 +48,6 @@ AC_DEFUN([gl_FUNC_STRERROR_R], >> [AC_LANG_PROGRAM( >> [[#include >>#include >> - int strerror_r (int, char *, size_t); >> ]],

Re: linkat, renameat dependencies

Eric Blake wrote: > I don't see renameat using stpcpy. Indeed. Committing the fix like this: 2011-05-23 Bruno Haible Eric Blake linkat, renameat: Update dependencies. * modules/renameat (Depends-on): Add dosname, save-cwd. Remove stpcpy. * modules/linkat

Re: linkat: simplify autoconf macro

On 05/21/2011 05:39 AM, Bruno Haible wrote: > Hi Eric, > > I see nothing in m4/linkat.c that requires prior use of gl_FUNC_LINK. > The dependency from 'linkat' to 'link' is a normal module dependency. > Objections to this patch? > > > 2011-05-21 Bruno Haible > > linkat: Simplify autoco

Re: strerror_r and POSIX

On 05/21/2011 11:45 AM, Bruno Haible wrote: > What about the platforms that don't return ERANGE when they truncate? > According to these > are AIX 6.1 and OSF/1 5.1. Are we sure that we override the system's > strerror_r() on these platforms?

Re: linkat, renameat dependencies

On 05/21/2011 05:26 AM, Bruno Haible wrote: > Hi Eric, > > Here's a proposed patch to update the dependencies of the modules 'linkat' > and 'renameat' to match the source code. > > - at-func2.c includes "dosname.h" and "save-cwd.h". > - I don't see calls to readlink(), stpcpy(), symlinkat() t

Re: [PATCH] maint.mk: generalize/improve the tight-scope rule

Jim Meyering wrote: > FYI, > Changes, in case anyone else is using this: > - XTERN is no longer supported, by default. > See the comments for how to customize it if you rely on this. > - you now get a diagnostic when the tight-scope syntax-check test is skipped > Subject: [PATCH] maint.mk:

[PATCH] maint.mk: generalize/improve the tight-scope rule

FYI, Changes, in case anyone else is using this: - XTERN is no longer supported, by default. See the comments for how to customize it if you rely on this. - you now get a diagnostic when the tight-scope syntax-check test is skipped >From 9df761edc6b29dbe2b7009b15dfe26a296d50a92 Mon Sep 17