On 05/21/2011 05:26 AM, Bruno Haible wrote: > Hi Eric, > > Here's a proposed patch to update the dependencies of the modules 'linkat' > and 'renameat' to match the source code. > > - at-func2.c includes "dosname.h" and "save-cwd.h". > - I don't see calls to readlink(), stpcpy(), symlinkat() there. > > > 2011-05-21 Bruno Haible <br...@clisp.org> > > linkat, renameat: Update dependencies. > * modules/renameat (Depends-on): Add dosname, save-cwd. > * modules/linkat (Depends-on): Likewise. Remove readlink, stpcpy, > symlinkat.
Looks like a nice idea, but it's not complete yet. > +++ modules/renameat Sat May 21 13:23:32 2011 > @@ -10,11 +10,13 @@ > stdio > extensions > fcntl-h > +dosname [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] > filenamecat-lgpl [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] > getcwd-lgpl [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] > openat [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] > rename [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] > same-inode [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] > +save-cwd [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] > stpcpy [test $HAVE_RENAMEAT = 0 || test $REPLACE_RENAMEAT = 1] I don't see renameat using stpcpy. ACK with that fixed. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
