Re: touch

2009-12-29 Thread ctrn3e8
On 12/29/2009 01:12 PM, Eric Blake wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to ctrn3e8 on 12/29/2009 11:58 AM: Re: touch --ref file1 -m file2 or touch -m file1 --ref file2 Does not work on ntfs-3g. See attached Thanks. That confirmed half of w

Re: link-warning usage improvements

2009-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 12/24/2009 1:46 PM: > Eric Blake wrote: >> Any objections to a patch that >> makes replacement of these headers unconditional, so that >> GNULIB_POSIXCHECK will work better? >> > > modules/spawn and modules/sys_times will

Re: licenses of tests

2009-12-29 Thread Ben Pfaff
Eric Blake writes: > For that matter, the following test modules can probably omit a 'Licenses:' > line; any objections to a patch along those lines? No objections from me on modules that I maintain. -- Ben Pfaff http://benpfaff.org

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Mike Frysinger
On Tuesday 29 December 2009 18:05:11 Eric Blake wrote: > Vladimir 'φ-coder/phcoder' Serbinenko gmail.com> writes: > > It's inconsistent with the rest of this file. > > That may be true, but it's not enough to worry about. i dont personally care one way or the other, but trunk gcc has sometimes

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Eric Blake
Eric Blake byu.net> writes: > but I'm inclined to not apply it. > > > It's inconsistent with the rest of this file. > > That may be true, but it's not enough to worry about. Clarification - I'm not inclined to apply it, because this is identical to upstream glibc. If you can convince Uli to

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Eric Blake
Vladimir 'φ-coder/phcoder' Serbinenko gmail.com> writes: > +#if (defined MB_CUR_MAX && HAVE_LOCALE_H && HAVE_WCTYPE_H && HAVE_ISWCTYPE && HAVE_WCSCOLL) || defined (_LIBC) Redundant parenthesis. If we were to apply this, it should be: defined _LIBC but I'm inclined to not apply it. > It's in

Re: licenses of tests

2009-12-29 Thread Eric Blake
Simon Josefsson josefsson.org> writes: > > files that suffer from the same fate, although I would like feedback before > > changing any of their licenses. > > > > I recognize some of my files in there, and using GPLv3+ for them should > be fine. Here's what I'll push, then. My sed script for

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Simon Josefsson wrote: > "Vladimir 'φ-coder/phcoder' Serbinenko" writes: > > >> === modified file 'gnulib/regex_internal.h' >> --- gnulib/regex_internal.h2009-12-27 15:37:18 + >> +++ gnulib/regex_internal.h2009-12-29 22:32:31 + >> @@ -58,7 +58,7 @@ >> # define SIZE_MAX ((size_t

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Simon Josefsson
"Vladimir 'φ-coder/phcoder' Serbinenko" writes: > === modified file 'gnulib/regex_internal.h' > --- gnulib/regex_internal.h2009-12-27 15:37:18 + > +++ gnulib/regex_internal.h2009-12-29 22:32:31 + > @@ -58,7 +58,7 @@ > # define SIZE_MAX ((size_t) -1) > #endif > > -#if (defined

lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
=== modified file 'gnulib/regex_internal.h' --- gnulib/regex_internal.h2009-12-27 15:37:18 + +++ gnulib/regex_internal.h2009-12-29 22:32:31 + @@ -58,7 +58,7 @@ # define SIZE_MAX ((size_t) -1) #endif -#if (defined MB_CUR_MAX && HAVE_LOCALE_H && HAVE_WCTYPE_H && HAVE_ISWCTYPE && H

Re: javacomp: portability fix

2009-12-29 Thread Eric Blake
Eric Blake byu.net> writes: > Oh, I finally see it now. There are only 84 bytes being translated; pre- patch, > the invocation was "tr [85] [84]", post-patch it is "tr [84] [84]". So the > problem was not with '-' (although that can potentially be problematic in its > own right), but in the

test-localename crash

2009-12-29 Thread Simon Josefsson
The test-localename test crashes for me: /bin/sh: line 5: 15913 Segmentation fault ${dir}$tst FAIL: test-localename Gdb says: (gdb) r Starting program: /home/jas/src/gnulib/m/gltests/test-localename Program received signal SIGSEGV, Segmentation fault. strcmp () at ../sysdeps/i386/i686/str

test-localename mingw failure?

2009-12-29 Thread Simon Josefsson
This rm -rf m && ./gnulib-tool --create-testdir --dir m --with-tests localename; cd m && ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu && make check yields i586-mingw32msvc-gcc -DHAVE_CONFIG_H -I. -I. -I. -I.. -I./.. -I../gllib -I./../gllib -g -O2 -MT test-localename.o -MD -

Re: touch

2009-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to ctrn3e8 on 12/29/2009 11:58 AM: > Re: touch --ref file1 -m file2 or touch -m file1 --ref file2 > Does not work on ntfs-3g. See attached Thanks. That confirmed half of what I was worried about. > valid/UTIME_NOW , make -k stuff > I d

Re: touch

2009-12-29 Thread ctrn3e8
On 12/28/2009 07:10 AM, Eric Blake wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to ctrn3e8 on 12/20/2009 10:04 PM: touch -m no longer seems to modify the file modification date. Archlinux, coreutils-8.2 (package coreutils-8.2-1-i686). Works if use coreutils-7.6.

Re: licenses of tests

2009-12-29 Thread Simon Josefsson
Eric Blake writes: > I noticed several of my recently written tests suffered from a copy-and-paste > license error (they stated GPLv2+, even though unit tests are generally v3+ > because they are not linked into the final product). Here are the remaining > files that suffer from the same fate

Re: javacomp: portability fix

2009-12-29 Thread Eric Blake
Ralf Wildenhues gmx.de> writes: > > The creation of a binary file from within javacomp.m4 created a wrong file > > on Solaris, because Solaris 'tr' (all of /usr/bin/tr, /usr/xpg4/bin/tr, > > /usr/xpg6/bin/tr) behave differently than GNU 'tr' in a particular case. > > I've tried to read the patch

Re: licenses of tests

2009-12-29 Thread Eric Blake
Eric Blake byu.net> writes: > I noticed several of my recently written tests suffered from a copy-and-paste > license error (they stated GPLv2+, even though unit tests are generally v3+ > because they are not linked into the final product). Here are the remaining > files that suffer from the

Re: javacomp: portability fix

2009-12-29 Thread Ralf Wildenhues
Hello Bruno, and hope y'all have had nice holidays, * Bruno Haible wrote on Sat, Dec 26, 2009 at 04:26:35PM CET: > The creation of a binary file from within javacomp.m4 created a wrong file > on Solaris, because Solaris 'tr' (all of /usr/bin/tr, /usr/xpg4/bin/tr, > /usr/xpg6/bin/tr) behave differe

Re: adding 2009 to copyright year lists

2009-12-29 Thread Jim Meyering
Jim Meyering wrote: > Eric Blake wrote: >> Jim Meyering meyering.net> writes: >> >>> Thanks for the feedback. >>> I've gone ahead and pushed the result as a single commit for 2009. >> >> I think we need to revert a couple of files, and figure out why they weren't >> picked up in your exemption fil

Re: adding 2009 to copyright year lists

2009-12-29 Thread Eric Blake
Jim Meyering meyering.net> writes: > > doc/gpl-3.0.texi|2 +- > > doc/lgpl-3.0.texi |2 +- > > Good catch. > > That happened because those two files are not listed in config/srclist.txt: > > $GNUWWWLICENSES/lgpl-3.0.txtdoc/COPYING.LESSERv3

Re: adding 2009 to copyright year lists

2009-12-29 Thread Eric Blake
Eric Blake byu.net> writes: > I think we need to revert a couple of files, and figure out why they weren't > picked up in your exemption file (so that when you repeat the exercise in three > more days for 2010, we don't repeat the mistake): > > doc/gpl-3.0.texi|2 +- > doc/lg

Re: adding 2009 to copyright year lists

2009-12-29 Thread Jim Meyering
Eric Blake wrote: > Jim Meyering meyering.net> writes: > >> Thanks for the feedback. >> I've gone ahead and pushed the result as a single commit for 2009. > > I think we need to revert a couple of files, and figure out why they weren't > picked up in your exemption file (so that when you repeat th

Re: adding 2009 to copyright year lists

2009-12-29 Thread Eric Blake
Jim Meyering meyering.net> writes: > Thanks for the feedback. > I've gone ahead and pushed the result as a single commit for 2009. I think we need to revert a couple of files, and figure out why they weren't picked up in your exemption file (so that when you repeat the exercise in three more d

Re: adding 2009 to copyright year lists

2009-12-29 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 12/28/2009 8:02 AM: >> I'm going to add 2009 to most copyright year lists >> that have not yet been updated this year. >> >> I'm doing it in several separate commits, but will probably squash >> these all into a single commit, in order to minimize lo

licenses of tests

2009-12-29 Thread Eric Blake
I noticed several of my recently written tests suffered from a copy-and-paste license error (they stated GPLv2+, even though unit tests are generally v3+ because they are not linked into the final product). Here are the remaining files that suffer from the same fate, although I would like feedb

Re: test-symlink failure on MinGW

2009-12-29 Thread Simon Josefsson
Eric Blake writes: > According to Simon Josefsson on 12/28/2009 11:51 PM: >> This patch looks a bit cleaner, it moves the system call into the >> function actually responsible for creating the same files. And it also >> fixes lstat self-tests. > > On the one hand, you are correct that it is nice

Re: test-symlink failure on MinGW

2009-12-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 12/28/2009 11:51 PM: > This patch looks a bit cleaner, it moves the system call into the > function actually responsible for creating the same files. And it also > fixes lstat self-tests. On the one hand, you are corre

Re: new module 'unused-parameter'

2009-12-29 Thread Jim Meyering
Simon Josefsson wrote: > Simon Josefsson writes: ... >> http://autobuild.josefsson.org/gnulib/log-200912271011859192000.txt >> >> Any ideas? > > The reason was that selinux/selinux.h was built before > unused-parameters.h, so the unused-parameters.h file that was inserted > into selinux/selinux.h