Re: Wrong explanation of getopts

2019-09-15 Thread Roland Illig
Am 15.09.2019 um 22:38 schrieb Eduardo Bustamante: > On Sun, Sep 15, 2019 at 12:58 PM Roland Illig wrote: >> >> The help text of getopts says: >> >>> Getopts normally parses the positional parameters ($0 - $9), but if >>> more arguments are given, they are parsed instead. > (...) >> The "inste

Re: Wrong explanation of getopts

2019-09-15 Thread Eduardo Bustamante
On Sun, Sep 15, 2019 at 12:58 PM Roland Illig wrote: > > The help text of getopts says: > > > Getopts normally parses the positional parameters ($0 - $9), but if > > more arguments are given, they are parsed instead. (...) > The "instead" in "they are parsed instead" is totally wrong. $1 to $9

help for "(( ))" uses straight quotes

2019-09-15 Thread Roland Illig
The help for "(( ))" says: > evaluation. Equivalent to "let EXPRESSION". All other help topics use `these' quotes.

Wrong explanation of getopts

2019-09-15 Thread Roland Illig
The help text of getopts says: > Getopts normally parses the positional parameters ($0 - $9), but if > more arguments are given, they are parsed instead. The positional parameter $0 (is it even called that way) is not parsed by getopts. Its only use might be in error messages, but I'm not sur

trailing whitespace in shortdoc

2019-09-15 Thread Roland Illig
The command "help alias | sed s,$,$," prints some lines with trailing whitespace. What is the purpose of this trailing whitespace? If there is none, it should not be generated at all. As a PO translator, I'm confused by that whitespace. Therefore it should be removed if possible.

double space in options to compgen

2019-09-15 Thread Roland Illig
The file complete.def contains: $SHORT_DOC complete ... [-W wordlist] [-F function] There should only be a single space between the brackets. This appears two times: in line 26 and in line 690.

imprecise wording in builtin usage

2019-09-15 Thread Roland Illig
In builtins.c, there is: "getopts optstring name [arg]" The "[arg]" should be replaced with "[arg ...]". In the same file there is: "exec [-cl] [-a name] [command [arguments ...]] [redirection ...]" The "arguments" should be replaced with "argument", since the "..." already says that there can

possible buffer overflow by bad translation

2019-09-15 Thread Roland Illig
>From siglist.c: sys_siglist[i] = (char *)xmalloc (10 + strlen (_("Unknown Signal #"))); sprintf (sys_siglist[i], _("Unknown Signal #%d"), i); If the translator doesn't look at the code using these two messages, they may be translated in a totally different way. L

typo in internal warning: the_pipeline

2019-09-15 Thread Roland Illig
internal_warning (_("add_process: process %5ld (%s) in the_pipeline"), (long)p->pid, p->command); What does "the_pipeline" mean? And why is an internal warning translated anyway? See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80055 for a discussion with the GCC project.

Syntax error in caller.def

2019-09-15 Thread Roland Illig
static char *caller_doc[] = { N_("Returns the context of the current subroutine call.\n\ \n\ Without EXPR, returns "$line $filename". With EXPR, returns\n\ "$line $subroutine $filename"; this extra information can be used to\n\ provide a stack trace.\n\ \n\ The value of EXP

Untranslatable string in help.def

2019-09-15 Thread Roland Illig
Hi, in help.def, the code reads: if (glob_pattern_p (list->word->word)) { printf ("%s", ngettext ("Shell commands matching keyword `", "Shell commands matching keywords `", (list->next ? 2 : 1))); print_word_list (list, ", "); printf ("'\n\n"); } The strings for trans