Thanks for the Vala doc patch, Reuben. Installed and closing. --best, karl.
On Mon, 29 Apr 2024 at 23:29, Karl Berry wrote:
>
> All I know about Vala is what you've written, but given that, I do agree
> it would be useful to document it. So a doc patch would be most welcome.
>
Attached.
--
https://rrt.sc3d.org
From eead600ffcf3d2ad56f2da25ea8371dca40432ea Mon Sep 17 0
so you have to give it all the source files at once,
Wow.
I guess it is worth documenting this limitation of the current Vala
support. If you agree with my reasoning above, then I will prepare a
documentation patch based on it.
All I know about Vala is what you've written, but g
On Sat, 27 Apr 2024 at 20:36, Reuben Thomas wrote:
> On Sat, 27 Apr 2024 at 00:53, Karl Berry wrote:
>
>> Reuben, any chance you can whomp up a test for this patch?
>>
>
> No problem, I will do this when I can find a moment. Since I don't
> actually need this fix after all, it may not be quick!
On Sat, 27 Apr 2024 at 00:53, Karl Berry wrote:
> Reuben, any chance you can whomp up a test for this patch?
>
No problem, I will do this when I can find a moment. Since I don't actually
need this fix after all, it may not be quick!
--
https://rrt.sc3d.org
Reuben, any chance you can whomp up a test for this patch?
I don't see a problem with the change, but it's always better to add a
test against future regressions, etc. --thanks, karl.
Attached, an updated patch that passes the tests. It uses GNU Make
functionality, but this is already required by the Vala support.
Thanks Ruben. I will peruse as soon as I have a chance, if no one else
gets there first ... -k
On Wed, 24 Apr 2024 at 23:38, Reuben Thomas wrote:
> Apologies, I should have run the tests before posting the patch. Indeed, I
> have broken things. So, please consider the documentation patch, and I'll
> take another look at the bug-fix (which in any case I have also realised
> does not solve m
On Wed, 24 Apr 2024 at 22:57, Reuben Thomas wrote:
>
> The patch is trivial, so hopefully it's obvious if there's a problem for
> some reason! I hope I explained well enough what problem I'm trying to
> solve.
>
Apologies, I should have run the tests before posting the patch. Indeed, I
have brok
I attach two patches. The first is a trivial documentation fix. The second
fixes a bug I ran into recently with Vala compilation.
I just needed to add some Vala source files to my program that are added to
the relevant _SOURCES variable conditionally:
if OS_WIN32
libenchant_la_SOURCES += api-wind
10 matches
Mail list logo
