Re: GSoC application review - reimplementing personal metadata importers

2013-06-16 Thread Alan Ezust
I really like the idea of having an importer/exporter so I can see ratings in other media players. Up to now, I've been using a program I wrote myself, that stores the amarok rating as an id3 Comment (Good, Fair, Very Good, Poor, etc) which is (compatible with | a relic from) Musicmatch Jukebox. I

Re: GSoC Application Review

2013-05-02 Thread Anmol Ahuja
On Thu, May 2, 2013 at 6:59 AM, Matěj Laitl wrote: > On 2. 5. 2013 Anmol Ahuja wrote: > > Short description: My > > proposal aims at revamping the Amarok scripting interface, and adding an > > intuitive Script Creator graphical application allowing easy script > > creation by non-coders and coder

Re: GSoC Application Review

2013-05-02 Thread Anmol Ahuja
On Thu, May 2, 2013 at 6:32 AM, Matěj Laitl wrote: > On 30. 4. 2013 Anmol Ahuja wrote: > > On Tue, Apr 30, 2013 at 3:56 AM, Matěj Laitl wrote: > > > Right, although I'd remove the "porting popular A 1.4 scripts" - there > are > > > more useful things you'll be able to do, like promoting Amarok >

Re: GSoC Application Review

2013-05-01 Thread Matěj Laitl
On 2. 5. 2013 Anmol Ahuja wrote: > Short description: My > proposal aims at revamping the Amarok scripting interface, and adding an > intuitive Script Creator graphical application allowing easy script > creation by non-coders and coders alike. (...) Please update the short description to match th

Re: GSoC Application Review

2013-05-01 Thread Matěj Laitl
On 30. 4. 2013 Anmol Ahuja wrote: > On Tue, Apr 30, 2013 at 3:56 AM, Matěj Laitl wrote: > > Right, although I'd remove the "porting popular A 1.4 scripts" - there are > > more useful things you'll be able to do, like promoting Amarok scripting, > > I'm not certain about how I would promote Amarok

Re: GSoC Application Review

2013-05-01 Thread Anmol Ahuja
On Thu, May 2, 2013 at 3:09 AM, Matěj Laitl wrote: > On 2. 5. 2013 Anmol Ahuja wrote: > > Here's a new version of the proposal. Some things like suspend inhibition > > and transcoding are still tentative, since I am awaiting a response to my > > previous email. > > I will respond to it as soon as

Re: GSoC Application Review

2013-05-01 Thread Matěj Laitl
On 2. 5. 2013 Anmol Ahuja wrote: > Here's a new version of the proposal. Some things like suspend inhibition > and transcoding are still tentative, since I am awaiting a response to my > previous email. I will respond to it as soon as I find time. > Also, the version of my proposal on the melange

Re: GSoC Application Review

2013-05-01 Thread Anmol Ahuja
On Tue, Apr 30, 2013 at 7:20 PM, Anmol Ahuja wrote: > > >> > - Synchronization Job >> >> Do you mean statistics synchronization? Perhaps even more useful would be >> to >> expose "Track matching job" is some way. > > Okay, I'll include Track matching job in the next revision. The > Synchroni

Re: GSoC application review - reimplementing personal metadata importers

2013-05-01 Thread Konrad Zemek
On 01.05.2013 08:52, Matěj Laitl wrote: On 1. 5. 2013 Konrad Zemek wrote: Amarok 2.x importer should support importing data from both a full mysql server and mysql-embedded file. To make reading from both sources simpler, existing MySqlStorage and MySqlEmbeddedStorage classes will be used. The i

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Matěj Laitl
On 1. 5. 2013 Konrad Zemek wrote: > Amarok 2.x importer should support importing data from both a full mysql > server and mysql-embedded file. To make reading from both sources simpler, > existing MySqlStorage and MySqlEmbeddedStorage classes will be used. The > importer's code should be as decoupl

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Konrad Zemek
On 01.05.2013 00:42, Matěj Laitl wrote: My bet that support code for actually using SqlCollection would be much heavier than implementing the A 2.x importer without it. Technical reasons not to use SqlCollection: 1. you'll be instantiating the beast just to use 2% of its functionality. SqlColl

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Matěj Laitl
On 1. 5. 2013 Konrad Zemek wrote: > Matěj Laitl wrote: > > Kondad wrote: > > > To ensure that metadata from current version of Amarok can always be > > > synchronized, Collections::SqlCollection class will be used > > > > I don't think this is a good idea at all. It is like using a cannon to > > s

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Konrad Zemek
On 30.04.2013 23:12, Matěj Laitl wrote: On 30. 4. 2013 Konrad Zemek wrote: Amarok 2.x importer should support importing data from both a full mysql server and mysql-embedded file. To ensure that metadata from current version of Amarok can always be synchronized, Collections::SqlCollection class

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Matěj Laitl
On 30. 4. 2013 Konrad Zemek wrote: > Amarok 2.x importer should support importing data from both a full mysql > server and mysql-embedded file. To ensure that metadata from current > version of Amarok can always be synchronized, Collections::SqlCollection > class will be used I don't think this is

Re: GSoC application review - reimplementing personal metadata importers

2013-04-30 Thread Konrad Zemek
Thank you for your tireless work! I outlined the changes below. I'm not posting the whole proposal this time since only two points were added in the text. On 29.04.2013 23:12, Matěj Laitl wrote Some more things to iron out about StatSyncing::Amarok2Provider: * would you support both a) conne

Re: GSoC Application Review

2013-04-30 Thread Anmol Ahuja
It wasn't supposed to be private, that was accidental. Resending it to the amarok-devel mailing list. Thanks for the thorough review :) On Tue, Apr 30, 2013 at 3:56 AM, Matěj Laitl wrote: > On 30. 4. 2013 Anmol Ahuja wrote: > > And for classes like CollectionLocation, should I create wrappers

Re: GSoC Application Review

2013-04-29 Thread Matěj Laitl
On 30. 4. 2013 Anmol Ahuja wrote: > And for classes like CollectionLocation, should I create wrappers like > CollectionLocationTypeExporter or simple modify the existing class, > changing script evokable functions to public slots/ Q_INVOKABLE? I think > the former would help keep the scripting logi

Re: GSoC application review - reimplementing personal metadata importers

2013-04-29 Thread Matěj Laitl
On 29. 4. 2013 Konrad Zemek wrote: > I introduced a few changes since last time I sent my proposal on review. > Unfortunately, because the proposal is already on Google Melange > website, it's now in HTML - and so I'm no longer maintaining the > contents in git repository, therefore there's no chan

Re: GSoC application review - reimplementing personal metadata importers

2013-04-29 Thread Konrad Zemek
I introduced a few changes since last time I sent my proposal on review. Unfortunately, because the proposal is already on Google Melange website, it's now in HTML - and so I'm no longer maintaining the contents in git repository, therefore there's no change log this time. :-( A few minor chan

Re: GSoC Application Review

2013-04-29 Thread Myriam Schweingruber
On Mon, Apr 29, 2013 at 3:28 PM, Anmol Ahuja wrote: > >> Just one remark about your availability: June 4 to June 17 is almost 2 >> weeks you will not be available, and according to your time-line you >> have quite some stuff planed for that time: >> >> June 31 - July 6 : Write QtScriptObject fo

Re: GSoC Application Review

2013-04-29 Thread Anmol Ahuja
> Just one remark about your availability: June 4 to June 17 is almost 2 > weeks you will not be available, and according to your time-line you > have quite some stuff planed for that time: > > June 31 - July 6 : Write QtScriptObject for Querymaker and > Bookmarks. Add accessor for QueryMaker to

Re: GSoC Application Review

2013-04-29 Thread Myriam Schweingruber
Hi Anmol, Thank you for your proposal. Just one remark about your availability: June 4 to June 17 is almost 2 weeks you will not be available, and according to your time-line you have quite some stuff planed for that time: June 31 - July 6 : Write QtScriptObject for Querymaker and Bookmarks.

Re: GSoC application review - reimplementing personal metadata importers

2013-04-28 Thread Konrad Zemek
On 29.04.2013 00:58, Matěj Laitl wrote: On 24. 4. 2013 Konrad Zemek wrote: September 09 - 15: Implementing two-way synchronization for remaining importers. September 16 - 22: Ironing out bugs, writing remaining tests. Cushion period in case of delays.

Re: GSoC application review - reimplementing personal metadata importers

2013-04-28 Thread Matěj Laitl
On 24. 4. 2013 Konrad Zemek wrote: > September 09 - 15: > Implementing two-way synchronization for remaining importers. > September 16 - 22: > Ironing out bugs, writing remaining tests. Cushion period in > case of delays. > September 23 - 29: FINAL EVALUATI

Re: GSoC application review - reimplementing personal metadata importers

2013-04-26 Thread Matěj Laitl
On 25. 4. 2013 Konrad Zemek wrote: > I'm a mature programmer. I have well over five years of real programming > experience (not the home-grown kind), and in that there's over half a > year of commercial experience. I'm not claiming I'm very experienced - > obviously five years is a lot less than te

Re: GSoC application review - reimplementing personal metadata importers

2013-04-25 Thread Konrad Zemek
On 25.04.2013 12:34, Matěj Laitl wrote: Oh, nice! Do mention it. I may be stating the obvious, but I felt it needs to be said: Please note that "ideal" code for a typical FLOSS project may be very different from "ideal" code for a programming contest. In Amarok, we try to keep code as simple (t

Re: GSoC application review - reimplementing personal metadata importers

2013-04-25 Thread Matěj Laitl
On 24. 4. 2013 Konrad Zemek wrote: > First, I added that my application has been discussed over on this > mailing list. I know that several projects highly favor students that > have engaged with the community about their project. Exactly. > Second, I mentioned > that I'm a titled finalist of

Re: GSoC application review - reimplementing personal metadata importers

2013-04-24 Thread Konrad Zemek
On 24.04.2013 13:19, Matěj Laitl wrote: Sounds good, except for the renaming. StatSyncing::ITunesProvider sounds well for both cases. I actually had a conception to leave importers where they are, or in a directory called simply importers. Well, for class names I'd stick to nomenclature of the

Re: GSoC application review - reimplementing personal metadata importers

2013-04-24 Thread Matěj Laitl
On 24. 4. 2013 Konrad Zemek wrote: > On 22.04.2013 14:56, Matěj Laitl wrote: > > I see, good luck with your exams! The deadline for proposals is May 3, so > > maybe you'll manage to at least submit a small change by then. > > I've just submitted a small patch which just "happened" as I was working

Re: GSoC application review - reimplementing personal metadata importers

2013-04-24 Thread Konrad Zemek
On 22.04.2013 14:56, Matěj Laitl wrote: On 21. 4. 2013 Konrad Zemek wrote: 2013/4/20 Matěj Laitl : On 20. 4. 2013 Konrad Zemek wrote: I think there are no importer tests, please check it and then be more certain in the proposal. I did actually check that, but the lack of tests is a bit unusual

Re: GSoC application review - reimplementing personal metadata importers

2013-04-22 Thread Matěj Laitl
On 21. 4. 2013 Konrad Zemek wrote: > 2013/4/20 Matěj Laitl : > > On 20. 4. 2013 Konrad Zemek wrote: > > I think there are no importer tests, please check it and then be more > > certain in the proposal. > > I did actually check that, but the lack of tests is a bit unusual for > me, so I figured th

Re: GSoC application review - reimplementing personal metadata importers

2013-04-22 Thread Konrad Zemek
2013/4/20 Matěj Laitl : > On 20. 4. 2013 Konrad Zemek wrote: >> Hi fellow developers, > > Hi, Hi Matěj, Thanks for the review. You do a lot of things around here. ;-) I incorporated all of your suggestions, but I wanted to reply on some points. >> For example I have experience with Boost, and >>

Re: GSoC application review - reimplementing personal metadata importers

2013-04-20 Thread Matěj Laitl
On 20. 4. 2013 Konrad Zemek wrote: > Hi fellow developers, Hi, > For example I have experience with Boost, and > submitted a bug report recently with a proposed fix, which was > promptly integrated into upstream. On the one hand that's experience > with developing and open source, on the other ha