amarok
>
>
> Description
> ---
>
> + Fixed search result appending process to prevent creation of invalid
> indices.
> + Added "Accept" header to musicbrainz request, because sometimes MusicBrainz
> returns response in JSON format instead of XML.
>
&g
.m.)
>
>
> Review request for Amarok.
>
>
> Bugs: 328359
> https://bugs.kde.org/show_bug.cgi?id=328359
>
>
> Repository: amarok
>
>
> Description
> ---
>
> + Fixed search result appending process to prevent creation of invalid
appending process to prevent creation of invalid indices.
+ Added "Accept" header to musicbrainz request, because sometimes MusicBrainz
returns response in JSON format instead of XML.
Diffs
-----
src/musicbrainz/MusicBrainzFinder.h beb155166f
src/musicbrainz/MusicBrainzFinder.cpp
prevent creation of invalid
> indices.
> + Added "Accept" header to musicbrainz request, because sometimes MusicBrainz
> returns response in JSON format instead of XML.
>
>
> Diffs
> -
>
> src/musicbrainz/MusicBrainzFinder.h beb155166f
> src/musicbrain
(updated)
-
Fix crash during musicbrainz search
Bugs: 328359
https://bugs.kde.org/show_bug.cgi?id=328359
Repository: amarok
Description
---
+ Fixed search result appending process to prevent creation of invalid indices.
+ Added "Accept" header to musicbrai
/show_bug.cgi?id=328359
Repository: amarok
Description
---
+ Fixed search result appending process to prevent creation of invalid indices.
+ Added "Accept" header to musicbrainz request, because sometimes MusicBrainz
returns response in JSON format instead of XML.
Diffs
-----
src/m
eLog? Another reason is that the patch doesn't
> > apply cleanly any more to current master. Alberto, would you mind rebasing
> > it? You'd be to best person to resolve the conflicts.
> >
> > As I've said earlier I have little competence to review the "low-
eLog? Another reason is that the patch doesn't
> > apply cleanly any more to current master. Alberto, would you mind rebasing
> > it? You'd be to best person to resolve the conflicts.
> >
> > As I've said earlier I have little competence to review the "low-level
d
be to best person to resolve the conflicts.
As I've said earlier I have little competence to review the "low-level"
MusicBrainz bits, but I trust Alberto in that manner.
src/musicbrainz/MusicBrainzFinder.cpp
<http://git.reviewboard.kde.org/r/105290/#comment23595>
I looks li
, [2] for inspiration
> >
> > [1]
> > http://techbase.kde.org/Policies/SVN_Commit_Policy#Special_keywords_in_SVN_log_messages
> > [2] http://dot.kde.org/2012/09/23/kde-commit-digest-22nd-july-2012
How does this sound for ChangeLog?
Update the MusicBrainz tagger to MusicB
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote:
> > src/musicbrainz/MusicBrainzTagsModel.cpp, lines 199-200
> > <http://git.reviewboard.kde.org/r/105290/diff/5/?file=139513#file139513line199>
> >
> > It would be a tiny bit safer to use index() instead
was added. It matches the
top result release ID in other *unselected* results, to make album tagging much
easier. Since a result might reference many release IDs (see the paragraph
above), the match is done on the whole list of them. This is highly recommended
over the "Select Best Matches&quo
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote:
> > src/musicbrainz/MusicBrainzTagsModel.cpp, lines 251-253
> > <http://git.reviewboard.kde.org/r/105290/diff/5/?file=139513#file139513line251>
> >
> > Should be that easy (if this
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote:
> > src/musicbrainz/MusicBrainzTagsModel.cpp, lines 251-253
> > <http://git.reviewboard.kde.org/r/105290/diff/5/?file=139513#file139513line251>
> >
> > Should be that easy (if this
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote:
> > src/musicbrainz/MusicBrainzTagsModel.cpp, lines 251-253
> > <http://git.reviewboard.kde.org/r/105290/diff/5/?file=139513#file139513line251>
> >
> > Should be that easy (if this
of this very useful feature.
That's what I was looking for: thanks!
> On April 18, 2013, 12:11 p.m., Matěj Laitl wrote:
> > src/musicbrainz/MusicBrainzFinder.h, line 26
> > <http://git.reviewboard.kde.org/r/105290/diff/5/?file=139505#file139505line26>
> >
> >
of a good suggestion. It
may give even better results because it prevents mixing different album
releases together."
to improve discoverability of this very useful feature.
src/musicbrainz/MusicBrainzFinder.h
<http://git.reviewboard.kde.org/r/105290/#comment23240>
nitpi
gt; Alberto Villa wrote:
> edit-clear looks better to me (see toolbar_wider.png above). I also
> rephrased the label to "Clear Choices", as there is nothing to reset to, here.
Right.
> On April 15, 2013, 10:47 p.m., Matěj Laitl wrote:
> > src/musicbrainz/Music
> On April 15, 2013, 12:54 p.m., Alberto Villa wrote:
> > src/musicbrainz/MusicBrainzTags.cpp, line 588
> > <http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588>
> >
> > Is this too hacky?
>
> Matěj
> On April 15, 2013, 10:47 p.m., Matěj Laitl wrote:
> > src/musicbrainz/MusicBrainzTags.h, line 124
> > <http://git.reviewboard.kde.org/r/105290/diff/4/?file=138928#file138928line124>
> >
> > I'd name this: resetAllChoices()
I used clearChoices() as i
> On April 15, 2013, 12:54 p.m., Alberto Villa wrote:
> > src/musicbrainz/MusicBrainzTags.cpp, line 588
> > <http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588>
> >
> > Is this too hacky?
>
> Matěj
ot;Select Best Matches from This Album" menu button was added. It matches the
top result release ID in other *unselected* results, to make album tagging much
easier. Since a result might reference many release IDs (see the paragraph
above), the match is done on the whole list of them. This is highl
> On April 15, 2013, 12:54 p.m., Alberto Villa wrote:
> > src/musicbrainz/MusicBrainzTags.cpp, line 588
> > <http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588>
> >
> > Is this too hacky?
>
> Matěj
> On April 15, 2013, 12:54 p.m., Alberto Villa wrote:
> > src/musicbrainz/MusicBrainzTags.cpp, line 588
> > <http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588>
> >
> > Is this too hacky?
>
> Matěj
> On April 15, 2013, 12:54 p.m., Alberto Villa wrote:
> > src/musicbrainz/MusicBrainzTags.cpp, line 588
> > <http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588>
> >
> > Is this too hacky?
Calling sort( ... Qt::Descending_or_how_it
d (this=0x40815c8) at
> > thread/qreadwritelock.cpp:149
> > #7 0x7ff6f91ea94d in QReadLocker::relock (this=0x7fff238ff570) at
> > /usr/include/qt4/QtCore/qreadwritelock.h:111
> > #8 0x7ff6f9437259 in MusicBrainzTagsItem::isChecked (this=0x40815a0)
> > at /ho
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105290/#review31090
---
src/musicbrainz/MusicBrainzTags.cpp
<h
to reflect the higher one. The "Go to ... Page" menu buttons
> currently link to the top result (i.e., highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches t
menu button was added. It matches the
top result release ID in other *unselected* results, to make album tagging much
easier. Since a result might reference many release IDs (see the paragraph
above), the match is done on the whole list of them. This is highly recommended
over the "Selec
ot; menu button was added. It matches the
> top result release ID in other *unselected* results, to make album tagging
> much easier. Since a result might reference many release IDs (see the
> paragraph above), the match is done on the whole list of them. This is highly
> recommended ov
Yep. That's why I have already fixed a bug in rekonq and presently working
on another "junior job" in amarok :)
N Thanks for the P.S.
On Sat, Feb 23, 2013 at 3:45 PM, Matěj Laitl wrote:
> On 22. 2. 2013 vedant agarwala wrote:
> > Matej, its good that Alberto is still working on it. It appears t
On 22. 2. 2013 vedant agarwala wrote:
> Matej, its good that Alberto is still working on it. It appears that I took
> your advice even before I read this email ;)
> I have started working on junior jobs and I can very well see there is a
> lot of work left to do. I am interested in this (the tag gu
Git commit 216c18bdaf18acf28e9ca98b115623934c9b4401 by Matěj Laitl.
Committed on 21/02/2013 at 01:30.
Pushed by laitl into branch 'master'.
Drop support for treating MusicBrainz ids as track unique ids
No comments on my mail inquiry, which I treat as a consent. Sin
track IDs (they are and will be used). Also, the
> score is updated to reflect the higher one. The "Go to ... Page" menu buttons
> currently link to the top result (i.e., highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Bes
highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *unselected* results, to make album tagging
> much easier. Since a result
Hi,
it has been brought to my attention on
https://bugs.kde.org/show_bug.cgi?id=315329 that MusicBrainz changed semantics
of the "MusicBrainz id" stored in various meta tags in a way that we IMO
cannot use it as track unique identifier any longer.
In short, the "MusicBrai
link to the top result (i.e., highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *unselected* results, to make album tagging
o ... Page" menu buttons
> currently link to the top result (i.e., highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *u
to ... Page" menu buttons
> currently link to the top result (i.e., highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *unselect
/r/105290/#scomment98>
I think you can use "toold-wizard" icon here.
src/musicbrainz/MusicBrainzTags.cpp
<http://git.reviewboard.kde.org/r/105290/#comment15647>
I've tried the latest code and it works well, but has an usability flaw:
When you are expan
ht add support for showing a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *unselected* results, to make album tagging
> much easier. Since a result might reference many release IDs (see the
>
dialogs/MusicBrainzTagger.cpp
<http://git.reviewboard.kde.org/r/105290/#comment14780>
Kudos for removing hidden functionality
src/musicbrainz/MusicBrainzFinder.h
<http://git.reviewboard.kde.org/r/105290/#comment14781>
Nitpick: we usually don't add blank line between undocumented m
Also, the
> score is updated to reflect the higher one. The "Go to ... Page" menu buttons
> currently link to the top result (i.e., highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Best Matches from This Album"
lt (i.e., highest scoring) IDs, but in the
> future I might add support for showing a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *unselected* results, to make album tagging
> much easier. Sinc
a list.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *unselected* results, to make album tagging
> much easier. Since a result might reference many release IDs (see the
> paragraph above), the match is don
ot; menu button was added. It matches the
top result release ID in other *unselected* results, to make album tagging much
easier. Since a result might reference many release IDs (see the paragraph
above), the match is done on the whole list of them. This is highly recommended
over the "Sel
:
/home/kash/workspace/amarok.git/src/musicbrainz/MusicBrainzFinder.cpp:441:114:
error: macro "Q_FOREACH" passed 3 arguments, but takes just 2
/home/kash/workspace/amarok.git/src/musicbrainz/MusicBrainzFinder.cpp:520:43:
error: macro "Q_FOREACH" passed 3 arguments, but takes just
t.
>
> A "Select Best Matches from This Album" menu button was added. It matches the
> top result release ID in other *unselected* results, to make album tagging
> much easier. Since a result might reference many release IDs (see the
> paragraph above), the match is done on
(see the paragraph
above), the match is done on the whole list of them. This is highly recommended
over the "Select Best Matches" toolbar button.
Process MusicDNS results just like MusicBrainz ones (i.e., do not duplicate the
logic). Simply, as they will not carry existing tags, they'l
e.. you'd have to build some kind of buffer (as I did) before this could
> work. otherwise musicbrainz will either hang or starve.
>
> Kevin Kofler wrote:
> > I just basically removes the ffmpeg stuff but puts nothing into place
> to replace it.
>
> Uh yes,
e.. you'd have to build some kind of buffer (as I did) before this could
> work. otherwise musicbrainz will either hang or starve.
>
> Kevin Kofler wrote:
> > I just basically removes the ffmpeg stuff but puts nothing into place
> to replace it.
>
> Uh yes,
---
>
> (Updated Jan. 25, 2011, 9:12 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> ---
>
> I added automatic adjustment of all columns and expanding of all tracks for
> the MusicBrainz dialog. Unfortunately, I haven't been able yet t
; ---
>
> I added automatic adjustment of all columns and expanding of all tracks for
> the MusicBrainz dialog. Unfortunately, I haven't been able yet to resize the
> dialog as well.
>
>
> Diffs
> -
>
> src/dialogs/MusicBrainzTagger.cpp 297d610
>
ve been removed in the latest git version of ffmpeg.
> This patch switches these to avcodec_decode_audio3 and AVMEDIA_TYPE_AUDIO
> respectively, removing deprecation warnings and fixing building on latest git
> ffmpeg.
>
>
> Diffs
> -
>
> src/musicbrainz/MusicDNSAud
c_decode_audio2 and the constant CODEC_TYPE_AUDIO are
> deprecated, and have been removed in the latest git version of ffmpeg.
> This patch switches these to avcodec_decode_audio3 and AVMEDIA_TYPE_AUDIO
> respectively, removing deprecation warnings and fixing building on late
.
Diffs
-
src/musicbrainz/MusicDNSAudioDecoder.cpp 6d82bb0
Diff: http://git.reviewboard.kde.org/r/101372/diff
Testing
---
Amarok builds successfully with latest git ffmpeg.
MusicBrainz tagging works correctly.
Thanks,
Sam
___
Amarok-devel
org/r/100443/
> ---
>
> (Updated Jan. 25, 2011, 9:12 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> ---
>
> I added automatic adjustment of all columns and expanding of all tracks for
> the MusicBrainz dialog. Unfortunately, I haven't been
org/r/100443/
> ---
>
> (Updated Jan. 25, 2011, 9:12 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> ---
>
> I added automatic adjustment of all columns and expanding of all tracks for
> the Mus
Fixed. Thank you. :)
2011/1/30 Martin :
> Hi,
>
>> I'll try to do something with this unreadable text, but could you
>> supply screenshot to make clear what exactly I need to fix.
> I just experienced the same :)
> Just use the Obidian Coast theme and you'll see what the problem is:
> http://www.a
Hi,
> I'll try to do something with this unreadable text, but could you
> supply screenshot to make clear what exactly I need to fix.
I just experienced the same :)
Just use the Obidian Coast theme and you'll see what the problem is:
http://www.abload.de/image.php?img=colorsd9fv.png
Regards,
Mart
Thank you very much for this review.
I'll try to do something with this unreadable text, but could you
supply screenshot to make clear what exactly I need to fix.
2011/1/30 Thomas Pfeiffer :
> A few days ago I tried out the MusicBrainz tagger in action for the first time
> and I&
A few days ago I tried out the MusicBrainz tagger in action for the first time
and I'm impressed! Although it started with disappointment since the first
tracks I tried could not be found either by MusicBrainz or by MusicDNS, later
on with other tracks it worked really well and actually t
visit:
> http://git.reviewboard.kde.org/r/100443/
> ---
>
> (Updated Jan. 25, 2011, 9:12 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> ---
>
> I added automatic adjustment of all columns and expandin
of all columns and expanding of all tracks for the
MusicBrainz dialog. Unfortunately, I haven't been able yet to resize the dialog
as well.
Diffs
-
src/dialogs/MusicBrainzTagger.cpp 297d610
Diff: http://git.reviewboard.kde.org/r/100443/diff
Testing
---
Screen
7581267
src/images/mb_aicon.png PRE-CREATION
src/images/mb_licon.png PRE-CREATION
src/images/mb_ticon.png PRE-CREATION
src/musicbrainz/MusicBrainzFinder.h 49c8f6b
src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa
src/musicbrainz/MusicBrainzMeta.h 57ed363
src/musicbrainz/MusicBrai
gger.cpp cdc3ec5
> src/dialogs/MusicBrainzTagger.ui 3f14236
> src/dialogs/TagDialog.cpp e98acf5
> src/images/CMakeLists.txt 7581267
> src/images/mb_aicon.png PRE-CREATION
> src/images/mb_licon.png PRE-CREATION
> src/images/mb_ticon.png PRE-CREATION
> src/music
t;
> src/CMakeLists.txt 9fcd33e
> src/dialogs/MusicBrainzTagger.h e33c9f6
> src/dialogs/MusicBrainzTagger.cpp cdc3ec5
> src/dialogs/MusicBrainzTagger.ui 3f14236
> src/dialogs/TagDialog.cpp e98acf5
> src/images/CMakeLists.txt 7581267
> src/images/mb_aicon.png
cf5
src/images/CMakeLists.txt 7581267
src/images/mb_aicon.png PRE-CREATION
src/images/mb_licon.png PRE-CREATION
src/images/mb_ticon.png PRE-CREATION
src/musicbrainz/MusicBrainzFinder.h 49c8f6b
src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa
src/musicbrainz/MusicBrainzMeta.h 57ed
2010/11/3 Thomas Pfeiffer :
> Maybe we can find someplace we can copy the weights from, these should not be
> left to guesswork. For example, I don't think Artist should be given such a
> low weight.
>
Tbh, I spied them from Picard. :)
2010/11/3 Lukas <1luk...@gmail.com>:
> How can selection titl
> I agree. Though leaving the best matches uncolored would have the
advantage of
> a "clean" list if there are mostly perfect matches, green should still
stay
> for the best matches.
How can selection title and artist have many "best" matches? Exact track is
made by an exact artist and has exact ti
2010/11/2 Lukas <1luk...@gmail.com>
>
> Hi,
>
> Its nice to see such improvement :)
>
> Just a few things to add - It looks like entire result gets compared to
> entire data from track. It's hardly the best way to it, since the longer
> correct part is, the more similar results looks like. From t
for Amarok.
> By Sergey Ivanov.
>
> *Updated 2010-11-02 15:32:21.079819*
> Changes
>
> Change gradients for results ( (orange) FFAA00->55FF00 (green) for
> MusicBrainz; (cyan)00AAFF->00FF55(green) for MusicDNS and green (00FF00) if
> track found by both engines).
>
---
Change gradients for results ( (orange) FFAA00->55FF00 (green) for MusicBrainz;
(cyan)00AAFF->00FF55(green) for MusicDNS and green (00FF00) if track found by
both engines).
Tooltips with match ratio.
Summary
---
Rebuild MBT dialog. Now search result presented by
> no Start search button any more, both searches run simultaneously.
>
> Will be Implemented soon:
> 1) If one TrackID founded by both searches, this result automatically moves
> on top.
> 2) MB icon linked to track page on musicbrainz.org. //need to find a place
> for It
> 3.
;
> Will be Implemented soon:
> 1) If one TrackID founded by both searches, this result automatically moves
> on top.
> 2) MB icon linked to track page on musicbrainz.org. //need to find a place
> for It
> 3..n Needs your advices. :)
>
>
> Diffs
> -
>
> src/C
> for It
> 3..n Needs your advices. :)
>
>
> Diffs
> -
>
> src/CMakeLists.txt 2abeca2
> src/dialogs/MusicBrainzTagger.h e33c9f6
> src/dialogs/MusicBrainzTagger.cpp cdc3ec5
> src/dialogs/MusicBrainzTagger.ui 3f14236
> src/musicbrainz/MusicBra
;
>
> Diffs
> -
>
> src/CMakeLists.txt 2abeca2
> src/dialogs/MusicBrainzTagger.h e33c9f6
> src/dialogs/MusicBrainzTagger.cpp cdc3ec5
> src/dialogs/MusicBrainzTagger.ui 3f14236
> src/musicbrainz/MusicBrainzFinder.h 49c8f6b
> src/musicbrainz/MusicBrai
top.
> 2) MB icon linked to track page on musicbrainz.org. //need to find a place
> for It
> 3..n Needs your advices. :)
>
>
> Diffs
> -
>
> src/CMakeLists.txt 2abeca2
> src/dialogs/MusicBrainzTagger.h e33c9f6
> src/dialogs/MusicBrainzTagger.cpp cdc
BrainzTagger.h e33c9f6
> src/dialogs/MusicBrainzTagger.cpp cdc3ec5
> src/dialogs/MusicBrainzTagger.ui 3f14236
> src/musicbrainz/MusicBrainzFinder.h 49c8f6b
> src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa
> src/musicbrainz/MusicBrainzMeta.h 57ed
isplay the
> the tracks to be tagged in the first level, and for each track display
> possible tag-sets in the second level. Using different colors for different
> matching distances sounds like a very good idea here. The user can then select
> the correct tag set for each track (if the
src/dialogs/MusicBrainzTagger.h e33c9f6
src/dialogs/MusicBrainzTagger.cpp cdc3ec5
src/dialogs/MusicBrainzTagger.ui 3f14236
src/musicbrainz/MusicBrainzFinder.h 49c8f6b
src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa
src/musicbrainz/MusicBrainzMeta.h 57ed363
src/musicbra
81 matches
Mail list logo
