----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100127/#review283 -----------------------------------------------------------
Ship it! Looks great now. Many thanks for the improvements! I think after the many fixes you made, this could go into Mainline. Best way to get more eyeballs on it. - Mark On 2010-11-04 11:20:27, Sergey Ivanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100127/ > ----------------------------------------------------------- > > (Updated 2010-11-04 11:20:27) > > > Review request for Amarok. > > > Summary > ------- > > Rebuild MBT dialog. Now search result presented by a Tree, > trackToSearch->SearchResults. Search results sorted by similarity ratio ( > more similar is on top ), and has different colors corresponding to that. > MusicDNS search results marked with a cyan color and stay on bottom. There is > no Start search button any more, both searches run simultaneously. > > Will be Implemented soon: > 1) DONE: If one TrackID founded by both searches, this result automatically > moves on top. > 2) DONE: MB icon linked to track page on musicbrainz.org. > 3..n Needs your advices. :) > > > Diffs > ----- > > src/CMakeLists.txt 9fcd33e > src/dialogs/MusicBrainzTagger.h e33c9f6 > src/dialogs/MusicBrainzTagger.cpp cdc3ec5 > src/dialogs/MusicBrainzTagger.ui 3f14236 > src/dialogs/TagDialog.cpp e98acf5 > src/images/CMakeLists.txt 7581267 > src/images/mb_aicon.png PRE-CREATION > src/images/mb_licon.png PRE-CREATION > src/images/mb_ticon.png PRE-CREATION > src/musicbrainz/MusicBrainzFinder.h 49c8f6b > src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa > src/musicbrainz/MusicBrainzMeta.h 57ed363 > src/musicbrainz/MusicBrainzTags.h PRE-CREATION > src/musicbrainz/MusicBrainzTags.cpp PRE-CREATION > src/musicbrainz/MusicBrainzTagsModel.h a93929a > src/musicbrainz/MusicBrainzTagsModel.cpp 1bf7389 > src/musicbrainz/MusicBrainzTrackListModel.h 6eaa648 > src/musicbrainz/MusicBrainzTrackListModel.cpp fa1fc10 > src/musicbrainz/MusicDNSFinder.h 2cd00d1 > src/musicbrainz/MusicDNSFinder.cpp 9c31f38 > > Diff: http://git.reviewboard.kde.org/r/100127/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/100127/s/12/ > > http://git.reviewboard.kde.org/r/100127/s/13/ > Context menu > http://git.reviewboard.kde.org/r/100127/s/14/ > > > Thanks, > > Sergey > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
