> On 2010-11-01 19:21:36, Stefan Derkits wrote: > > The Colours in the Screenshot look a little bit strange (especially this > > really light blue) and could need some Refinement > > And the Selection which Set of Tags to use should maybe be made by > > selecting it, instead of using checkboxes (because you can only select one > > tagset) > > otherwise a good Improvement :) > > Sergey Ivanov wrote: > I tried to make gradient Red->Green ( through orange ), but It looked > terrible, that's why I dropped blue color component. Color for MusicDNS was > taken "from a roof", It's a simple Qt::cyan. They all can be changed, i.e. > waiting for your advices. :) > I think that checkboxes much more clear for understanding of selection > precess then simple row selection, and It prevents from: "WTF happened with > my tags, I didn't mean to accept this crap!?" > Btw mass-selection still available by clicking on a first header column, > It automatically select all top results, except tracks that already has > result selected by user. > > Thomas Pfeiffer wrote: > Looks good so far. But checkboxes are definitely the wrong control if > only one can be selected. Is it possible to use radio buttons? > The mass selection sounds like a useful feature, although I'd have to see > it in action to see if it can be understood. > > Stefan Derkits wrote: > Maybe another Idea would be to use no Colour. First, because it's hard to > find Colours that look good in every Colour Scheme and second because a small > percentage of Colour Blind Users can't see them. So maybe instead of using > Colours, make an additional Collumn where you show the "Similarity Ratio" as > a numerical Value. Does MusicDNS not support any kind of Information "how > good the Results are"?
Well, in general I find color usage a good thing. However, as has been said, getting the colors right can be challenging. Or maybe not? :) Right, Amarok will do it for you, automatically. We have a class that generates the best contrasting colors. Check "PaletteHandler", I think that's the one. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100127/#review261 ----------------------------------------------------------- On 2010-11-01 18:35:41, Sergey Ivanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100127/ > ----------------------------------------------------------- > > (Updated 2010-11-01 18:35:41) > > > Review request for Amarok. > > > Summary > ------- > > Rebuild MBT dialog. Now search result presented by a Tree, > trackToSearch->SearchResults. Search results sorted by similarity ratio ( > more similar is on top ), and has different colors corresponding to that. > MusicDNS search results marked with a cyan color and stay on bottom. There is > no Start search button any more, both searches run simultaneously. > > Will be Implemented soon: > 1) If one TrackID founded by both searches, this result automatically moves > on top. > 2) MB icon linked to track page on musicbrainz.org. //need to find a place > for It > 3..n Needs your advices. :) > > > Diffs > ----- > > src/CMakeLists.txt 2abeca2 > src/dialogs/MusicBrainzTagger.h e33c9f6 > src/dialogs/MusicBrainzTagger.cpp cdc3ec5 > src/dialogs/MusicBrainzTagger.ui 3f14236 > src/musicbrainz/MusicBrainzFinder.h 49c8f6b > src/musicbrainz/MusicBrainzFinder.cpp 41ddbaa > src/musicbrainz/MusicBrainzMeta.h 57ed363 > src/musicbrainz/MusicBrainzTagsModel.h a93929a > src/musicbrainz/MusicBrainzTagsModel.cpp 1bf7389 > src/musicbrainz/MusicBrainzTrackListModel.h 6eaa648 > src/musicbrainz/MusicBrainzTrackListModel.cpp fa1fc10 > src/musicbrainz/MusicDNSFinder.h 2cd00d1 > src/musicbrainz/MusicDNSFinder.cpp 9c31f38 > > Diff: http://git.reviewboard.kde.org/r/100127/diff > > > Testing > ------- > > > Screenshots > ----------- > > Refreshed view of MusicBrainz tagger > http://git.reviewboard.kde.org/r/100127/s/10/ > Wide range diviation example, colors goes from red to green > http://git.reviewboard.kde.org/r/100127/s/11/ > > > Thanks, > > Sergey > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
