This revision was automatically updated to reflect the committed changes.
wbauer marked an inline comment as done.
Closed by commit R181:cea336303aaf: Fix passing local file paths on the command
line (authored by wbauer).
REPOSITORY
R181 Amarok
CHANGES SINCE LAST UPDATE
https://phabricator.k
wbauer marked an inline comment as done.
wbauer added inline comments.
INLINE COMMENTS
> wbauer wrote in App.cpp:280
> It does handle relative paths just fine, see the test plan. (I just tried
> `./foo.ogg` to be sure)
> QUrl::fromUserInput() passes the directory to QDir(), which assumes '.' if
fvogt accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D21478
To: wbauer, #amarok, fvogt
Cc: fvogt, amarok-devel
wbauer added inline comments.
INLINE COMMENTS
> fvogt wrote in App.cpp:280
> Did it previously also handle relative paths such as `./foo.ogg`? If so,
> passing `QDir::currentPath()` instead of a null string is AFAICT necessary.
It does handle relative paths just fine, see the test plan. (I just
fvogt added inline comments.
INLINE COMMENTS
> App.cpp:280
> {
> -QUrl url( m_args->positionalArguments().at( i ) );
> +QUrl url( QUrl::fromUserInput( m_args->positionalArguments().at(
> i ), QString(), QUrl::AssumeLocalFile ) );
> //TODO:PORTME
Di
wbauer edited the test plan for this revision.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D21478
To: wbauer, #amarok
Cc: amarok-devel
wbauer edited the summary of this revision.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D21478
To: wbauer, #amarok
Cc: amarok-devel
wbauer edited the summary of this revision.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D21478
To: wbauer, #amarok
Cc: amarok-devel
wbauer created this revision.
wbauer added a reviewer: Amarok.
wbauer added a project: Amarok.
Herald removed a project: Amarok.
Herald added a subscriber: amarok-devel.
wbauer requested review of this revision.
REVISION SUMMARY
Use QUrl::fromUserInput() to handle local file paths (without "file
