wbauer created this revision. wbauer added a reviewer: Amarok. wbauer added a project: Amarok. Herald removed a project: Amarok. Herald added a subscriber: amarok-devel. wbauer requested review of this revision.
REVISION SUMMARY Use QUrl::fromUserInput() to handle local file paths (without "file://") as well. `QUrl::AssumeLocalFiles` is passed to avoid DNS lookups for non-existent/mistyped file names. TEST PLAN Created a file 1d5d9dD.oga in /home/wolfi/Desktop/ (anything will do of course). Ran: - amarok file:///home/wolfi/Desktop/1d5d9dD.oga - amarok /home/wolfi/Desktop/1d5d9dD.oga - amarok 1d5d9dD.oga The file was opened and played sucessfully in all cases, whereas before only the first one worked (with phonon-backend-gstreamer at least). Tested with both phonon-backend-gstreamer and phonon-backend-vlc. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D21478 AFFECTED FILES src/App.cpp To: wbauer, #amarok Cc: amarok-devel