wbauer added inline comments.

INLINE COMMENTS

> fvogt wrote in App.cpp:280
> Did it previously also handle relative paths such as `./foo.ogg`? If so, 
> passing `QDir::currentPath()` instead of a null string is AFAICT necessary.

It does handle relative paths just fine, see the test plan. (I just tried 
`./foo.ogg` to be sure)
QUrl::fromUserInput() passes the directory to QDir(), which assumes '.' if 
empty.

I just noticed that amarok has a "--cwd" command line option though (that is 
currently ignored AFAICS), it would probably be good to pass that instead.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D21478

To: wbauer, #amarok
Cc: fvogt, amarok-devel

Reply via email to