://git.reviewboard.kde.org/r/110036/diff/
Testing
---
Quick check using the script console that presets can be changed.
The preset does get applied but it won't show in the EqualizerDialog.
Possible other bugs.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing
script console that presets can be changed.
The preset does get applied but it won't show in the EqualizerDialog.
Possible other bugs.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/lis
script console that presets can be changed.
The preset does get applied but it won't show in the EqualizerDialog.
Possible other bugs.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/lis
/diff/
Testing (updated)
---
Quick check using the script console that presets can be changed.
The preset does get applied but it won't show in the EqualizerDialog.
Possible other bugs.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
A
or restart.
Pressing stop and then play will make it continue with the correct preset
enabled.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
dialogue wouldn't compile without getting a bool.
8 (What does restore do?)
I'm still not certain. The dialogue needed it but if it does what I think
it does from the updated patch* then it probably
isn't needed as the current behaviour of the dialogue seems to obsolete it.
*
e with the correct preset
enabled.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
Testing
---
Checked that Amarok compiles and that the equalizer dialogue still works. Found
that enabling/dis-enabling the equalizer forces the track to freeze or restart.
Pressing stop and then play will make it continue with the correct preset
enabled.
Thanks,
Ryan
On Aug. 16, 2012, 10:18 a.m., Ryan McCoskrie wrote:
> > How do we continue? Is this ready to be submitted? What is the actual
> > functionality? Can you also add a line for the ChangeLog.txt?
Will try to get a related patch (equalizer controller) into Amarok first. With
that d
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103999/#review17840
---
On Aug. 19, 2012, 10:09 p.m., Ryan McCoskrie wrote:
>
> ---
: http://git.reviewboard.kde.org/r/103999/diff/
Testing (updated)
---
Checked that the code compiles with the playground option enabled.
Since there is no active code, this should be sufficiant.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
ly generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106067/#review17649
---
On Aug. 18, 2012, 1:26 a.m., Ryan McCoskrie wrote:
>
> ---
> This is an automatica
it that as a separate review? Tracks.
Done.
- Ryan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103999/#review17516
---
On Feb
dependancies from /playground/CMakeLists.txt that
/CMakeLists.txt and /src/CMakeLists.txt
Diffs
-
playground/CMakeLists.txt e96aa3f
Diff: http://git.reviewboard.kde.org/r/106067/diff/
Testing
---
Checked that it compiles. No discrernable differences.
Thanks,
Ryan McCoskrie
discrernable differences.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
owever I'll start afresh.
- Ryan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102798/#review17511
---
On Nov. 18, 2011, 11:
language controls.
This patch works fine.
- Ryan McCoskrie
On March 26, 2012, 6:50 a.m., Ryan McCoskrie wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.
This patch is simply a case of copying, pasting, substituteing artist with
composer so new bugs are extremely unlikely.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
t:
http://git.reviewboard.kde.org/r/104327/#review11530
---
On March 18, 2012, 6:27 a.m., Ryan McCoskrie wrote:
>
> ---
> This is an automatically generated e-
to have a different musician name to the
composer name and pressed button. Everything works as expected.
This patch is simply a case of copying, pasting, substituteing artist with
composer so new bugs are extremely unlikely.
Thanks,
Ryan McCoskrie
expected.
This patch is simply a case of copying, pasting, substituteing artist with
composer so new bugs are extremely unlikely.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
()
returns 'Unknown Artist' in place of an empty QString. This will render the
data checking needless under
all known circumstances.
Screenshots
---
Uses meta-data instead of raw file path
http://git.reviewboard.kde.org/r/102236/s/220/
Thanks,
Ryan
meta-data instead of raw file path
http://git.reviewboard.kde.org/r/102236/s/220/
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
.kde.org/r/102236/s/220/
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
I would suggest going back to 1.6 as 1.7 isn't yet available as a stable
package on Mageia.
--
Ryan McCoskrie
North Canterbury, New Zealand
sourcelinksnotes.comyr.com
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
>
> So what features do you have planned or would strongly suggest to make
> it into 2.6?
> I'll follow up later with my own shortlist.
>
I've got lots of codeing time coming up so I'll probably be able to get my
second attempt at an equalizer scripting interface written
I've started to wonder if I should make a new class to hold
this behaviour?
--
Ryan McCoskrie
North Canterbury, New Zealand
sourcelinksnotes.comyr.com
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
eq() seems to return no value.
# First Revision #
0: Opened script console and Equalizer Dialog. Used both the dialog and
Amarok.Engine.currentPreset property
to alter the equalizer. Everything appears to work properly.
Thanks,
Ryan
qBandsFreq() seems to return no value.
# First Revision #
0: Opened script console and Equalizer Dialog. Used both the dialog and
Amarok.Engine.currentPreset property
to alter the equalizer. Everything appears to work properly.
Thanks,
Ryan
rtist names,
failing to detect albums and showing all manner of other strange bugs.
--
Ryan McCoskrie
North Canterbury, New Zealand
sourcelinksnotes.comyr.com
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
warning against building Amarok without support of
taglib if it is attempted.
Diffs
-
CMakeLists.txt 6fb0491
Diff: http://git.reviewboard.kde.org/r/103090/diff/diff
Testing
---
Built Amarok with this patch applied.
Thanks,
Ryan McCoskrie
rst-timers.
- Ryan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102798/#review7162
---
On Oct. 7, 2011, 2:43 a.m.,
script console. Works as expected.
0: Amarok.Engine.eqBandsFreq() seems to return no value.
Thanks,
Ryan McCoskrie
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102236/
---
(Updated Sept. 10, 2011, 10:26 p.m.)
Review request for Amarok.
Changes
arokConfig::equalizerPresetsNames();
}
It returns an empty array. Could someone point out what I am doing wrong?
I'm pretty sure I could get it all right once I'm put on the right course.
--
Ryan McCoskrie
North Canterbury, New Zealand
sourcelinksnotes.comyr.com
signature.asc
Description:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102236/
---
Review request for Amarok.
Summary
---
Fix for bug 263693. When the u
On 8 August 2011 10:26, Sam Lade wrote:
>
> As Bart said, please submit patches to http://git.reviewboard.kde.org/
> (you'll need an account with identity.kde.org, if I remember correctly),
> rather than the mailing list. It makes everything much neater and easier
> to keep track of - things on t
ateImpl.cpp
index 349464c..a3ec56f 100644
--- a/src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp
+++ b/src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp
@@ -1,4 +1,5 @@
/****
+
38 matches
Mail list logo
