----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102798/ -----------------------------------------------------------
(Updated Nov. 18, 2011, 8:54 p.m.) Review request for Amarok. Summary (updated) ----------------- Support for equalizer scripts and plugins. WIP. Description (updated) ------- This patch is the beginning of an effort to make a generic equalizer interface for plugins and scripts to access. 0: Gives the EngineController controller class new functions for examining, choosing and altering presets. 0: AmarokEngineScript provides functions to access the simpler equalizer functions in EngineController. 0: EqualizerDialog now uses the The::engineController() as a back end. WARNING: I don't properly understand how the equalizer works. The largest changes in this patch are mostly code moved from EqualizerDialog to EngineController. It's quite ugly in places. Diffs ----- src/EngineController.h 3da2f23 src/EngineController.cpp 5bea5c6 src/dialogs/EqualizerDialog.h 9dad055 src/dialogs/EqualizerDialog.cpp ddcd300 src/scriptengine/AmarokEngineScript.h f1cdb8c src/scriptengine/AmarokEngineScript.cpp 395c504 Diff: http://git.reviewboard.kde.org/r/102798/diff/diff Testing (updated) ------- 0: Briefly tested the Amarok.Engine.eqChangeCurrentPreset() function in the script console. Works as expected. 0: Amarok.Engine.eqBandsFreq() seems to return no value. #################### # First Revision # #################### 0: Opened script console and Equalizer Dialog. Used both the dialog and Amarok.Engine.currentPreset property to alter the equalizer. Everything appears to work properly. Thanks, Ryan McCoskrie
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
