Re: Review Request: Add a CMake switch for building playground

2011-08-09 Thread Martin Blumenstingl
> On Aug. 8, 2011, 6:14 p.m., Martin Blumenstingl wrote: > > Sorry, it seems that reviewboard ate my comment :( Here's the original text: Please speak up in the next few days if something speaks AGAINST committing this (otherwise I'll commit next week). The patch itself

Auto-hiding amarok's tray icon

2011-08-09 Thread Martin Blumenstingl
Hi Aaron, it seems that you don't really like the way most applications' tray icons of behave nowadays (they always show up, no matter if the application needs attention or not). If this makes sense or not probably depends on the user's point of view ;) In konversation it's easy to follow your po

Re: Review Request: Add a CMake switch for building playground

2011-08-09 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102077/#review5520 --- - Martin On July 24, 2011, 6:29 p.m., Martin Blumenstingl

Review Request: Add a CMake switch for building playground

2011-07-24 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102077/ --- Review request for Amarok. Summary --- It seems that up to now everyo

Re: Review Request: Coverbling applet build KO in current git

2011-07-24 Thread Martin Blumenstingl
> On July 24, 2011, 6:06 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 0cc4eb24c951b29e4f140d8c7e3bd7e5d79f6654 by Manu Wagner to branch master. Thanks for the patch - and sorry that it took so long to get it included. - Martin -

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/ --- (Updated June 5, 2011, 5:05 p.m.) Review request for Amarok. Changes ---

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-05 Thread Martin Blumenstingl
ications". - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/#review3676 --- On June 4, 2011, 8:36 p.m., Martin Blu

Review Request: Do not show the OSD if a fullscreen application is active

2011-06-04 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/ --- Review request for Amarok. Summary --- It can be quite annoying if fu

Re: Review Request: Fix multiple issues with the lyrics applet/engine

2011-03-20 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100892/ --- (Updated March 20, 2011, 3:52 p.m.) Review request for Amarok and Rick W.

Re: Review Request: Fix multiple issues with the lyrics applet/engine

2011-03-19 Thread Martin Blumenstingl
and update() already check if the lyrics were really updated. src/context/engines/lyrics/LyricsEngine.cpp <http://git.reviewboard.kde.org/r/100892/#comment1718> See what the comment says, that code-block was simply misplaced.

Review Request: Fix multiple issues with the lyrics applet/engine

2011-03-19 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100892/ --- Review request for Amarok and Rick W. Chen. Summary --- This fixes th

Review Request: Fix Applet::showMessage for KDE 4.6 and trunk

2011-02-09 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100617/ --- Review request for Amarok. Summary --- There were multiple bugs in li

Re: Review Request: Make NetworkAccessManagerProxy::getData honor redirects

2011-01-02 Thread Martin Blumenstingl
direct) we have to update the URL (= the key) in the QHash. - Martin On 2011-01-02 20:25:45, Martin Blumenstingl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://gi

Review Request: Make NetworkAccessManagerProxy::getData honor redirects

2011-01-02 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100285/ --- Review request for Amarok and Rick W. Chen. Summary --- Currently Net

Re: Review Request: Improve lyrics applet

2010-11-15 Thread Martin Blumenstingl
artin On 2010-11-13 17:38:22, Martin Blumenstingl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100013/ > --

Re: Review Request: Improve lyrics applet

2010-11-07 Thread Martin Blumenstingl
op of yours at > > g...@git.kde.org:clones/amarok/rickc/amarok branch > > rr/improve-lyrics-applet-v3. Please try it out and see if there are any > > other problems. Thanks. > > Martin Blumenstingl wrote: > There's one issue remaining: sometimes the te

Re: Review Request: Improve lyrics applet

2010-11-07 Thread Martin Blumenstingl
------ On 2010-11-06 17:18:27, Martin Blumenstingl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100013/ > -

Re: Review Request: Improve lyrics applet

2010-11-06 Thread Martin Blumenstingl
ile3209line92> > > > > if ( -> if( Done. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/#review308 -

Re: Review Request: Improve lyrics applet

2010-11-06 Thread Martin Blumenstingl
'm not sure yet how to fix this. It looks like it's not possible to set a custom brush for showMessage(). - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/#re

Re: Review Request: Improve lyrics applet

2010-11-06 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/ --- (Updated 2010-11-06 17:18:27.760440) Review request for Amarok. Changes

Re: Review Request: Improve lyrics applet

2010-11-04 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/ --- (Updated 2010-11-04 18:37:00.435783) Review request for Amarok. Changes

Review Request: Improve lyrics applet

2010-11-04 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100013/ --- Review request for Amarok. Summary --- This fixes multiple issues wit