D11170: Use new kpackage_install_bundled_package macro

markey accepted this revision. markey added a comment. This revision is now accepted and ready to land. Restricted Application removed a project: Amarok. Restricted Application added a subscriber: amarok-devel. Ubuntu 18.04 is now released, and your patch builds fine with it. REPOSITORY R181

D11170: Use new kpackage_install_bundled_package macro

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11170 To: malteveerman, #amarok, markey Cc: amarok-devel, markey, heikobecker, #amarok

D12492: Fixed fadebars

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D12492 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D12492: Fixed fadebars

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D12492 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D12316: Some analyzer applet tweaks

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D12316 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D12316: Some analyzer applet tweaks

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D12316 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D12315: Fixed crash at shutdown

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D12315 To: malteveerman, #amarok, markey Cc: anthonyfieroni, #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingr

D12315: Fixed crash at shutdown

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D12315 To: malteveerman, #amarok, markey Cc: anthonyfieroni, #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, ma

D12223: Improvements to CurrentTrack applet

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D12223 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D12223: Improvements to CurrentTrack applet

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D12223 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11968: More interface stuttering work

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11968 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D11968: More interface stuttering work

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11968 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11862: Get rid of scripting

markey added a comment. See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild. I was discussing about this with Heiko. Maybe QtScript could b

D11868: Reduce interface stuttering

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11868 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11868: Reduce interface stuttering

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11868 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D11867: Logger overhaul

markey closed this revision. markey added a comment. Pushed to master. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11867 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktim

D11867: Logger overhaul

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11867 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D11788: Fixed wrong slot signatures in BrowserMessageArea

This revision was automatically updated to reflect the committed changes. Closed by commit R181:5176c93e41e4: Fixed wrong slot signatures in BrowserMessageArea (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11788

D11788: Fixed wrong slot signatures in BrowserMessageArea

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11788 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D11787: Small MySQL libraries fix for tests.

This revision was automatically updated to reflect the committed changes. Closed by commit R181:ef7ec2c70f60: Small MySQL libraries fix for tests. (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11787?vs=30863&id=

D11787: Small MySQL libraries fix for tests.

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11787 To: malteveerman, #amarok, markey Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, t

D11534: Some small changes and fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R181:16d825772150: Some small changes and fixes (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11534?vs=30067&id=30529 R

D11534: Some small changes and fixes

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11534 To: malteveerman, #amarok, markey Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar

D11349: Reactivate wikipedia applet

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R181:7a63540fc23a: Reactivate wikipedia applet (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok C

D11349: Reactivate wikipedia applet

markey requested changes to this revision. markey added a comment. This revision now requires changes to proceed. Generally this works for me now, but there are two more issues that I found: If the optional Qt5WebEngine is not found, we get a CMake error anyway: =

D11349: Reactivate wikipedia applet

markey requested changes to this revision. markey added a comment. This revision now requires changes to proceed. Fails to build here: /home/mark/devel/src/amarok/src/context/AppletModel.cpp: In member function ‘QUrl Context::AppletModel::imageUrl(const QString&, const QString&)’: /home

D11299: Fixed a crash in magnatune service

This revision was automatically updated to reflect the committed changes. Closed by commit R181:d527cce9963c: Fixed a crash in magnatune service (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11299?vs=29436&id=29

D11299: Fixed a crash in magnatune service

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11299 To: malteveerman, #amarok, markey Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar

D11171: Port NetworkAccessManager to new signal/slot syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R181:12d7ecbfe6e8: Port NetworkAccessManager to new signal/slot syntax (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D111

D11171: Port NetworkAccessManager to new signal/slot syntax

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11171 To: malteveerman, #amarok, markey Cc: markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise, tbettler, Smar

D11192: Ported playdar collection away from qjson

This revision was automatically updated to reflect the committed changes. Closed by commit R181:16d4997c3792: Ported playdar collection away from qjson (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11192?vs=2916

D11192: Ported playdar collection away from qjson

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11192 To: malteveerman, #amarok, markey Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar

D11171: Port NetworkAccessManager to new signal/slot syntax

markey requested changes to this revision. markey added a comment. This revision now requires changes to proceed. This does not build for me (GCC 7.2.0). Error: https://pastebin.com/5Pmk1ELp REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11171 To: malteveerman,

Re: Amarok 2.9.0 "Hibernaculum" released

So if you don't want to go through the hassle of checking it out from Git, you could simply delete that one line in the source code, as indicated by Heiko's linked patch. Sorry for the trouble :) Mark On Fri, Mar 9, 2018 at 8:42 AM, Heiko Becker wrote: > Hello Michał, > > On 03/08/18 12:57, M

D11150: Use Kirigami's spacing and icon sizes and remove own implementation

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11150 To: malteveerman, #amarok, markey Cc: markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11150: Use Kirigami's spacing and icon sizes and remove own implementation

markey accepted this revision. markey added a comment. This revision is now accepted and ready to land. Kirigami2 seems really nifty. Nice choice. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D11150 To: malteveerman, #amarok, markey Cc: markey, #amarok

D11033: Fix some deprecation warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R181:c9257ade2df7: Fix some deprecation warnings (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11033?vs=28634&id=28974

D11033: Fix some deprecation warnings

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D11033 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis,

Re: A proposal to release 2.9

Hi, no crash on exit for me with latest master. I'll try to figure this out with Heiko on IRC. Is anyone else here getting this crash? Mark On Sun, Mar 4, 2018 at 1:50 PM, Heiko Becker wrote: > Hi, > > On 02/24/18 23:58, Stefano Pettini wrote: > > it looks like there's a general agreement o

D10923: Make Webkit optional

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH webkit-optional REVISION DETAIL https://phabricator.kde.org/D10923 To: heikobecker, #amarok, markey Cc: markey, paul, yaohanchen, malteveerman, cochise, tbettler, Smar, ricktimmi

D10923: Make Webkit optional

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10923 To: heikobecker, #amarok, markey Cc: markey, paul, yaohanchen, malteveerman, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D10924: Disable Discogs and Google cover search temporarily

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10924 To: heikobecker, #amarok, markey Cc: paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D10924: Disable Discogs and Google cover search temporarily

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH disable-cover-search-providers REVISION DETAIL https://phabricator.kde.org/D10924 To: heikobecker, #amarok, markey Cc: paul, yaohanchen, malteveerman, markey, cochise, tbettler, S

D10978: Port tests to Qt5/KF5

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10978 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D10978: Port tests to Qt5/KF5

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10978 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis,

D10971: Fixed a crash in analyzer applet when sample rate reported by engine controller is zero

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10971 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D10971: Fixed a crash in analyzer applet when sample rate reported by engine controller is zero

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10971 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis,

D10900: Ported importers to Qt5/KF5

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10900 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D10900: Ported importers to Qt5/KF5

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10900 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis,

D10923: Make Webkit optional

markey added a comment. Is this patch meant for master? Because the branch is "webkit-optional". REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10923 To: heikobecker, #amarok Cc: markey, paul, yaohanchen, malteveerman, cochise, tbettler, Smar, ricktimmis, asturmlech

D10831: Ported some services to Qt5/KF5

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok, markey Cc: asturmlechner, #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Sm

D10831: Ported some services to Qt5/KF5

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok, markey Cc: asturmlechner, #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, schweingruber

D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10819 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber

D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

markey added a comment. Hey Malte, please fix your real name for the next patch. KDE commit hook rejects this: remote: Audit failure - Commit 9ecce24b6dfe11a2c67a395d5826f6a7f4296749 - Non-full name: maldela REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.k

D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10819 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis,

D10708: New context area

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10708 To: malteveerman, #amarok, markey Cc: asturmlechner, heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, schweingruber

D10708: New context area

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10708 To: malteveerman, #amarok, markey Cc: asturmlechner, heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise,

Re: A proposal to release 2.9

Hello Heiko, this sounds like a good proposal. I can also provide some help as I've done releases in the past. About merging KF5 branch into master, I'm not sure how feasible this is considering that both branches have diverged a lot. Perhaps we will need to ask the admins to switch (or rather re

D10526: Port core application away from kdelibs4

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok, markey Cc: heikobecker, asturmlechner, stikonas, kpiwowarski, markey, spettini, #amarok, paul, yaohanchen, malteveerman, cochise, tbettler, Smar, ricktimmis, sc

D10526: Port core application away from kdelibs4

markey accepted this revision. markey added a comment. This revision is now accepted and ready to land. Looks good to me. Builds and works fine too. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok, markey Cc: heikobecker,

D10526: Port core application away from kdelibs4

markey added a comment. In D10526#206680 , @spettini wrote: > Can I suggest we release 2.9 as planned, with the current state and maybe > some more bugfixes, before integrating this patch? Once migration to kf5 is > complete, and new patches

Fwd: D8229: streamlined plugin system

Forwarded to get more exposure. FYI, sysadmins have now also subscribed this mailing list to Phabricator, so in the future we will get notifications. -- Forwarded message -- From: Malte Veerman Date: Mon, Oct 9, 2017 at 11:53 PM Subject: D8229: streamlined plugin system To: krets

Re: Review Request 115154: Analyzer applet ASCII visualizer

git master. Shall we commit this patch for you, or do you have commit rights for the KDE git repo? - Mark Kretschmann On Jan. 20, 2014, 4:04 p.m., Matej Repinc wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 118861: GSoC Review 1: parsing and highlighting of lyrics

ontext/applets/lyrics/LyricsApplet.cpp <https://git.reviewboard.kde.org/r/118861/#comment42353> trimmed can be made const when newLrc() takes a const reference. - Mark Kretschmann On June 21, 2014, 11:42 a.m., Vedant Agarwala wrote: > > -

Re: Invitation for Randa Meetings 2014

On Fri, Feb 14, 2014 at 9:30 AM, Mark Kretschmann wrote: > Dear Multimedianistas, > > we are happy to announce that there will be a "Randa Meetings" event > in 2014, and it is also planned to have a multimedia track there. If > you have already been at a Randa event, yo

Invitation for Randa Meetings 2014

lways activities planned to explore the surroundings. More detailed information (booking, etc) will soon be available from our organizer Mario Fux. It would be nice if we could already get a general overview of who would be interested in coming. Please reply to this email thread. Regards,

Re: Review Request 110036: WIP - Simple equalizer scripting

> On July 2, 2013, 10:50 a.m., Mark Kretschmann wrote: > > Any news on this? Could you please upload the patch again? > > Matěj Laitl wrote: > There has been no feedback for 6 months and I believe this could have > been superseded by Scripting GSoC 2013 project ->

[amarok] tests: Fix compilation with unit tests enabled.

Git commit 5b3c84b29c16931e46bf7e1ddba16095245ce070 by Mark Kretschmann. Committed on 14/12/2013 at 09:25. Pushed by markey into branch 'master'. Fix compilation with unit tests enabled. The problem was clashing symbols between KDE's kWarning macro and gmock. Thanks go to Edwar

Re: Build errors with GMock

Erm, I meant s/Clang 1.7/GMock 1.7 On Fri, Dec 13, 2013 at 6:57 AM, Mark Kretschmann wrote: > Hey all, > > lately I'm getting strange errors when building Git master with unit > tests. At first I thought it was just my configuration (GMock 1.6, > Clang), but now another user

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

oard, it's not to be taken literally. Of course we can commit it for you :) I'll do it tonight when I'm back home. - Mark Kretschmann On Dec. 12, 2013, 10:51 a.m., Martin Brodbeck wrote: > > --- > This is an automa

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114406/#review45583 --- Ship it! Ship It! - Mark Kretschmann On Dec. 11, 2013, 2

Re: Review Request 113876: Linking error in newly created files

ttp://git.reviewboard.kde.org/r/113876/#comment32396> * Q_OBJECT Macro is missing * "AcustId" looks like a typo of AcoustId. - Mark Kretschmann On Nov. 15, 2013, 9:54 a.m., Vedant Agarwala wrote: > > --- >

Re: Review Request 113390: GSoC 2013 Revamping Scripting - Part 6/6 : Misc src/

ot; src/configdialog/dialogs/ScriptsConfig.cpp <http://git.reviewboard.kde.org/r/113390/#comment31458> Can be changed to: return findSpecFile( subdir ); - Mark Kretschmann On Oct. 22, 2013, 4:06 p.m., Anmol Ahuja wrote: > > -

Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113389/#review43819 --- Ship it! Ship It! - Mark Kretschmann On Oct. 22, 2013, 4

Re: Review Request 113387: GSoC 2013 Revamping Scripting - Part 4/6 : Script Console

ent31454> Remove commented out code. src/scripting/scriptconsole/ScriptConsole.cpp <http://git.reviewboard.kde.org/r/113387/#comment31453> Remove commented out code. - Mark Kretschmann On Oct. 22, 2013, 4:06 p.m., Anmol Ahuja wrote: > > -

Re: Review Request 113386: GSoC 2013 Revamping Scripting - Part 3/6 : Scripts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113386/#review43812 --- Ship it! Ship It! - Mark Kretschmann On Oct. 22, 2013, 4

Re: Review Request 113385: GSoC 2013 Revamping Scripting - Part 2/6 : Script Manager

385/#comment31450> Why are these functions commented out? Please remove completely if no longer used. - Mark Kretschmann On Oct. 22, 2013, 4:07 p.m., Anmol Ahuja wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 113384: GSoC 2013 Revamping Scripting - Part 1/6 : Scripting wrappers

ttp://git.reviewboard.kde.org/r/113384/#comment31447> I think it is confusing to abuse the "slots" keyword like this. Is there an alternative? Or at least a comment should be added. - Mark Kretschmann On Oct. 22, 2013, 4:07 p.m., A

[amarok] /: Enable C++11 features, as discussed with other core devs.

Git commit 271ebaed8bd29a7ca78707fa6a696418c7c008b3 by Mark Kretschmann. Committed on 20/10/2013 at 16:09. Pushed by markey into branch 'master'. Enable C++11 features, as discussed with other core devs. Let the fun begin :) CCMAIL: amarok-devel@kde.org M +2-0CMakeLists

[amarok] /: Rewrite Block Analyzer to use pure OpenGL instead of QGLPaintEngine2.

Git commit f4a3f4fcf59cc0c592bd6d703542cb162a19721c by Mark Kretschmann. Committed on 19/07/2013 at 08:37. Pushed by markey into branch 'master'. Rewrite Block Analyzer to use pure OpenGL instead of QGLPaintEngine2. This rewrite should fix a number of issues that users had, especially

Re: Changes in GMock

s nightmare). Try to erase the thought of writing this from your memory. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org ht

Changes in GMock

nce the packaging to some degree if we can find a better solution. -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail

Re: Added support for Visualizations using VSXu

On Tue, Sep 10, 2013 at 7:50 PM, Konrad Zemek wrote: > On 10.09.2013 13:22, Mark Kretschmann wrote: >> >> On Sun, Sep 8, 2013 at 9:04 PM, Dinesh wrote: >>> >>> Hi Folks, >>> >>> Finally done adding support for Visualizations using VSXu.(!!!) >

Re: Added support for Visualizations using VSXu

re out what's wrong yet (could be an issue with my Intel driver, or something else). If any of you folks want to try it too, that would be great, so we can see if the problem is reproducible elsewhere. If you have any build issues we can help. -- Mark Kretschmann Amarok Developer Fel

Re: Amarok Scripting API

t; QString description > bool isNull > QString customValue > QString url > public slots: > bool save(); > void initFromString( const QString & urlString ); > bool run(); > void removeFromDb(); > QStrin

Re: Review Request 112417: FIX: 283022 - Performance with large feed (6000 items) very poor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112417/#review39570 --- Ship it! Looks good to me. - Mark Kretschmann On Aug. 31

Re: SoK - Implementing cue sheet and embedded cue sheet support in Amarok

___ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel > -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org __

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112266/#review38939 --- Ship it! Ship It! - Mark Kretschmann On Aug. 30, 2013, 1

Re: Amarok Scripting API

On Wed, Aug 28, 2013 at 7:05 PM, Anmol Ahuja wrote: >> I think he means that the grey ones existed from before and the black ones >> were added by him. > Yep, that's it. > I'm sorry, I should've clarified. Right, but I see three different colors. Grey, a very

Re: Amarok Scripting API

On Wed, Aug 28, 2013 at 3:48 PM, Anmol Ahuja wrote: > Here's the current state of the Amarok Scripting API. : Thanks Anmol. Now please also explain what the different colors mean. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/m

Re: Need a mentor for an SoK idea

name). > Also, now that I had a look at my propoasl from the SoK site, I see that all > the formatting, HTML links and even whitespaces other than space, have been > removed. Now it just looks like a ugly long paragraph :( That's terrible indeed. Could you edit the text and format it bet

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

Matěj Laitl wrote: > I don't think that TagLib itself is origin of the string, I think it just > reads the identifier that is in the actual tag (which can vary file by file). > Or perhaps you can prove me wrong by pointing out relevant part of TagLib > source code? > >

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

> On Aug. 25, 2013, 12:06 p.m., Matěj Laitl wrote: > > shared/tag_helpers/APETagHelper.cpp, lines 33-37 > > > > > > Hmm, is there a specification somewhere that says what the proper > > identifiers are? I fear of

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109369/#review38520 --- What's the current status of this patch? - Mark Kretsc

Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

? - Mark Kretschmann On July 31, 2013, 6:22 p.m., Vedant Agarwala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110426: KWalletHelper class for services using the KWallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/#review38518 --- Any news for this patch? - Mark Kretschmann On May 20, 2013

Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left overs)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112221/ --- (Updated Aug. 25, 2013, 8:45 a.m.) Status -- This change has been mar

Re: Review Request 112169: Stop after current track to tray menu

ome. I am wondering though why the keyboard shortcut doesn't suffice. - Mark Kretschmann On Aug. 20, 2013, 2:50 a.m., Shitikanth Kashyap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 112248: 313504: prefer QLatin1String

deteriorates code readability for very little performance gain. Frank, most of the checks on EBN are for micro-optimizations. They are low hanging fruit, and as such they generally make sense to follow, but there are corner cases like this one where the cost outweighs the benefits. - Mark

Re: ToolTips and Automatic Formatting

On Fri, Aug 16, 2013 at 10:44 AM, Mark Kretschmann wrote: > Heya, > > as we noticed recently, many of Amarok's ToolTips look very ugly and > have readability issues because they are not formatted. Therefore a > longer ToolTip is being rendered as one giant long line. The Qt AP

  1   2   3   4   >