----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113876/#review45408 -----------------------------------------------------------
src/tagguessing/acustid/Acustidprovider.h <http://git.reviewboard.kde.org/r/113876/#comment32396> * Q_OBJECT Macro is missing * "AcustId" looks like a typo of AcoustId. - Mark Kretschmann On Nov. 15, 2013, 9:54 a.m., Vedant Agarwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113876/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 9:54 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > I am stuck at this undefined reference errors: > http://pastebin.kde.org/pcb6qgj78 > Basically the MusicBrainzFiner class inherits the TagGuessing::Provider > class. I tried to create a new Tagguessing library but it would always lead > to "cyclic dependencies" in CMake. > Finally I added all the tagguessing classes (i.e. the classes in dir > "tagguessing" and its sub dirs) to amaroklib. Even then I am getting the > linking errors. I added the AMAROK_EXPORT macro to these classes but still > the same error was being produced so I reverted. > > > Diffs > ----- > > src/tagguessing/acustid/Webservicequeryer.cpp PRE-CREATION > src/tagguessing/musicbrainz/CMakeLists.txt PRE-CREATION > src/tagguessing/musicbrainz/MusicBrainzFinder.h PRE-CREATION > src/tagguessing/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION > src/tagguessing/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION > src/tagguessing/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION > src/tagguessing/musicbrainz/MusicDNSFinder.h PRE-CREATION > src/tagguessing/musicbrainz/MusicDNSFinder.cpp PRE-CREATION > src/tagguessing/musicbrainz/MusicDNSXmlParser.h PRE-CREATION > src/tagguessing/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION > CMakeLists.txt 4ffee3a > ChangeLog ad84f5b > cmake/modules/FindLibChromaprint.cmake PRE-CREATION > src/CMakeLists.txt 70fb67b > src/context/applets/analyzer/BlockAnalyzer.h df0506b > src/context/applets/analyzer/BlockAnalyzer.cpp 6325774 > src/dialogs/MusicBrainzTagger.h bef0621 > src/dialogs/MusicBrainzTagger.cpp 591f087 > src/dialogs/MusicBrainzTagger.ui 156f8d3 > src/dialogs/OrganizeCollectionDialog.h 88fa08d > src/dialogs/OrganizeCollectionDialog.cpp 1c14710 > src/dialogs/OrganizeCollectionDialogBase.ui 85d0ec8 > src/dialogs/TagDialog.h 626f903 > src/dialogs/TagDialog.cpp 48aadd9 > src/dialogs/TagDialogBase.ui 7ed36ea > src/dialogs/WebServicesTagger.h PRE-CREATION > src/dialogs/WebServicesTagger.cpp PRE-CREATION > src/dialogs/WebServicesTagger.ui PRE-CREATION > src/musicbrainz/MusicBrainzFinder.h beb1551 > src/musicbrainz/MusicBrainzFinder.cpp 9a1b3bb > src/musicbrainz/MusicBrainzMeta.h 6e21232 > src/musicbrainz/MusicBrainzTagsItem.h 6852c9f > src/musicbrainz/MusicBrainzTagsItem.cpp 0941a90 > src/musicbrainz/MusicBrainzTagsModel.h eaee7f8 > src/musicbrainz/MusicBrainzTagsModel.cpp 0ffb284 > src/musicbrainz/MusicBrainzTagsModelDelegate.h d276af7 > src/musicbrainz/MusicBrainzTagsModelDelegate.cpp a11c9c3 > src/musicbrainz/MusicBrainzTagsView.h 6997e34 > src/musicbrainz/MusicBrainzTagsView.cpp 96cbd17 > src/musicbrainz/MusicBrainzXmlParser.h c7f9e72 > src/musicbrainz/MusicBrainzXmlParser.cpp 290a275 > src/musicbrainz/MusicDNSAudioDecoder.h ca98c20 > src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b > src/musicbrainz/MusicDNSFinder.h 90c4c9c > src/musicbrainz/MusicDNSFinder.cpp d393211 > src/musicbrainz/MusicDNSXmlParser.h 982861d > src/musicbrainz/MusicDNSXmlParser.cpp 1f3f54f > src/tagguessing/AudioToQStringDecoder.h PRE-CREATION > src/tagguessing/AudioToQStringDecoder.cpp PRE-CREATION > src/tagguessing/CMakeLists.txt PRE-CREATION > src/tagguessing/Finder.h PRE-CREATION > src/tagguessing/Finder.cpp PRE-CREATION > src/tagguessing/Meta.h PRE-CREATION > src/tagguessing/Provider.h PRE-CREATION > src/tagguessing/Provider.cpp PRE-CREATION > src/tagguessing/TagsItem.h PRE-CREATION > src/tagguessing/TagsItem.cpp PRE-CREATION > src/tagguessing/TagsModel.h PRE-CREATION > src/tagguessing/TagsModel.cpp PRE-CREATION > src/tagguessing/TagsModelDelegate.h PRE-CREATION > src/tagguessing/TagsModelDelegate.cpp PRE-CREATION > src/tagguessing/TagsView.h PRE-CREATION > src/tagguessing/TagsView.cpp PRE-CREATION > src/tagguessing/WebRequestsHandler.h PRE-CREATION > src/tagguessing/WebRequestsHandler.cpp PRE-CREATION > src/tagguessing/acustid/Acustidprovider.h PRE-CREATION > src/tagguessing/acustid/Acustidprovider.cpp PRE-CREATION > src/tagguessing/acustid/CMakeLists.txt PRE-CREATION > src/tagguessing/acustid/Fingerprintcalculator.h PRE-CREATION > src/tagguessing/acustid/Fingerprintcalculator.cpp PRE-CREATION > src/tagguessing/acustid/Webservicequeryer.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113876/diff/ > > > Testing > ------- > > > Thanks, > > Vedant Agarwala > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
