----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113387/#review43814 -----------------------------------------------------------
src/scripting/scriptconsole/ScriptConsole.h <http://git.reviewboard.kde.org/r/113387/#comment31452> Why is this class commented out? Never keep commented out code, unless there is a very good reason to, and also an extra comment explaining why it is there. src/scripting/scriptconsole/ScriptConsole.cpp <http://git.reviewboard.kde.org/r/113387/#comment31456> Remove commented out code. src/scripting/scriptconsole/ScriptConsole.cpp <http://git.reviewboard.kde.org/r/113387/#comment31455> Please clean up this function. src/scripting/scriptconsole/ScriptConsole.cpp <http://git.reviewboard.kde.org/r/113387/#comment31454> Remove commented out code. src/scripting/scriptconsole/ScriptConsole.cpp <http://git.reviewboard.kde.org/r/113387/#comment31453> Remove commented out code. - Mark Kretschmann On Oct. 22, 2013, 4:06 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113387/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2013, 4:06 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > The new script console. > > > Diffs > ----- > > src/scripting/scriptconsole/CompletionModel.h PRE-CREATION > src/scripting/scriptconsole/CompletionModel.cpp PRE-CREATION > src/scripting/scriptconsole/ScriptConsole.h PRE-CREATION > src/scripting/scriptconsole/ScriptConsole.cpp PRE-CREATION > src/scripting/scriptconsole/ScriptConsoleItem.h PRE-CREATION > src/scripting/scriptconsole/ScriptConsoleItem.cpp PRE-CREATION > src/scripting/scriptconsole/ScriptEditorDocument.h PRE-CREATION > src/scripting/scriptconsole/ScriptEditorDocument.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113387/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
