Re: Fix for MySQL embedded permissions error on upgrading to MySQL 5.5

On Wed, Mar 23, 2011 at 00:08, Nikhil Marathe wrote: > On Tue, Mar 22, 2011 at 11:54 PM, Ian Monroe wrote: >> It does, but unlike my branch, Nikhil's solution is good for master. >> > Should I commit this? I did. ___ Amarok-de

Re: Fix for MySQL embedded permissions error on upgrading to MySQL 5.5

It does, but unlike my branch, Nikhil's solution is good for master. Ian On Sun, Mar 20, 2011 at 13:38, Alex Merry wrote: > Isn't this what Ian's eean-mysql5.5.9fix branch fixes? > > Alex > > > > On 20/03/11 17:45, Nikhil Marathe wrote: >> Hi, >> >> If any user/developer updates to MySQL 5.5 (fo

Re: mysql_upgrade issue for libmysqld and amarok

On Fri, Mar 18, 2011 at 05:44, Kristian Nielsen wrote: > This is a follow up on a discussion I had with eean on Freenode IRC #maria. > > The issue is how to upgrade libmysqd from MySQL version 5.1 to version 5.5 (or > more generally any major version upgrade), in particular as relates to > Amarok'

Re: mysql 5.5 may require mysql_upgrade

That's good to know. :) Ian On Fri, Mar 11, 2011 at 07:08, Alex Merry wrote: > Your branch works for me (with mysql 5.5.9), but I didn't have to (and > never have) run mysql_upgrade. > > Alex > > > > On 06/03/11 02:47, Ian Monroe wrote: >> First off mys

mysql 5.5 may require mysql_upgrade

First off mysql 5.5 apparently ignores the MYSQL_HOME, which is disappointing. The branch eean-mysql5.5.9fix addresses this. I had to run mysql_upgrade before it would work though. mysql_library_init just returned non-zero until I ran it, so I assume that was the problem. mysql_upgrade is general

Re: Review Request: mysql embedded default options

> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent.

Re: Review Request: mysql embedded default options

> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent.

Re: Review Request: mysql embedded default options

> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent.

Re: Re : Google Summer Of Code

On Sun, Feb 6, 2011 at 15:42, Bart Cerneels wrote: > Hey Kevin, > > I had an idea for a playlist-sharing plugin based on Telepathy. This > would make it possible to share playlists over jabber, gtalk, faceboko > chat and many other IM services. I'll post that idea to the wiki soon. > Sounds cool,

Re: Review Request: mysql embedded default options

> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent.

Re: Review Request: mysql embedded default options

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100345/#review829 --- The current way we do it is because if you have a MySQL that rand

Re: Review Request: Fetch cover for DAAP Albums #240060

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100176/#review446 --- Does DAAP not have images available? - Ian On 2010-11-28 15:03

Re: RFC: develop feature branches in main repo

On Tue, Nov 9, 2010 at 9:57 AM, Leo Franchi wrote: > On Tuesday, November 09, 2010 09:50:29 AM Ian Monroe wrote: >> I know some people are still using Gitorious repos and such for the >> ongoing work. However recently everyone has been granted the right to >> create branch

RFC: develop feature branches in main repo

I know some people are still using Gitorious repos and such for the ongoing work. However recently everyone has been granted the right to create branches on our git.kde.org/amarok.git repo. I think it would raise the visibility of feature branches if everyone just pushed them to the main repo. Thi

Re: Review Request: Update PlaydarCollection and related components to use QWeakPointer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100141/#review329 --- Mostly gcc is the best reviewer for this sort of stuff. So the "i

Re: Podcast Engine

g 05 November 2010 schrieb Ian Monroe: >> On Fri, Nov 5, 2010 at 12:36 PM, Conrad Hübler > wrote: >> > Hi folks, >> > >> > I'm planning (at the moment just an idea) to add a podcastengine and >> > podcastapplet to the amarok context view listing

Re: Podcast Engine

On Fri, Nov 5, 2010 at 12:36 PM, Conrad Hübler wrote: > Hi folks, > > I'm planning (at the moment just an idea) to add a podcastengine and > podcastapplet to the amarok context view listing latest podcasts as the album > applet does. > > How can I query the podcasts? I just found a way to get one

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100132/#review291 --- src/MediaDeviceCache.cpp

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

> On 2010-11-04 16:18:16, Ian Monroe wrote: > > src/MediaDeviceCache.cpp, line 218 > > <http://git.reviewboard.kde.org/r/100132/diff/1/?file=3179#file3179line218> > > > > Maybe a comment here explaining why iPods shouldn't use the following > > c

Re: Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100132/#review287 --- src/MediaDeviceCache.cpp

Re: handling of "ship it"

On Wed, Nov 3, 2010 at 10:54 AM, Lydia Pintscher wrote: > Heya folks > > In the last days I've seen a few occurences of the following: > > * patch gets submitted to reviewboard > * patch gets very quick review > * ship it is clicked by one person or more > * patch gets commited > * person most fam

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

> On 2010-11-02 20:44:50, Ian Monroe wrote: > > With the latest changes, it looks good to me. > > Stefan Derkits wrote: > The Problem is that due to the Changes in SqlMeta it doesn't apply > cleanly. But I'm unable to read the "Git Conflict Syntax"

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review273 --- Ship it! With the latest changes, it looks good to me. - Ian

Re: Review Request: Refactoring. Year is now an int and createDate an uint in Meta.

> On 2010-10-31 16:52:44, Leo Franchi wrote: > > look okay to me, will test with it in a bit. > > Maximilian Kossick wrote: > Definitely not ship it. We should move all return types to QDateTime > instead of the uint which is a left over form A1, instead of removing the one > place where i