Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/ --- (Updated May 30, 2013, 11:18 p.m.) Review request for Amarok. Changes --

Re: Review Request 108717: nepomuk: implement custom QueryMaker

> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp, line 428 > > > > > > QScopedPointer please > > Matěj Laitl wrote: > Dropped? Why? Dropp

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 30, 2013, 10:56 a.m., Matěj Laitl wrote: > > Looks good, although I've spotted last error: > > 1. add a normal sorting, e.g. Album > > 2. expand the leftmost arrow down, click Shuffle > > 3. the Album sorting is not reset (as it should be; other "normal" sorting > > items correctly rese

Re: Review Request 108717: nepomuk: implement custom QueryMaker

> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 30, 2013, 7:12 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 30, 2013, 10:56 a.m., Matěj Laitl wrote: > > Looks good, although I've spotted last error: > > 1. add a normal sorting, e.g. Album > > 2. expand the leftmost arrow down, click Shuffle > > 3. the Album sorting is not reset (as it should be; other "normal" sorting > > items correctly rese

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 30, 2013, 10:56 a.m., Matěj Laitl wrote: > > Looks good, although I've spotted last error: > > 1. add a normal sorting, e.g. Album > > 2. expand the leftmost arrow down, click Shuffle > > 3. the Album sorting is not reset (as it should be; other "normal" sorting > > items correctly rese

Re: Review Request 108717: nepomuk: implement custom QueryMaker

> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > Very good work, Edward! I especially like how elegantly is the nepomuk > > query constructed and nicely separated classes that participate on that. > > > > Sorry for being a bit of bitchy with code style, but please have in mind > > that by

Re: Review Request 108717: nepomuk: implement custom QueryMaker

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 30, 2013, 6:44 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 30, 2013, 10:56 a.m., Matěj Laitl wrote: > > Looks good, although I've spotted last error: > > 1. add a normal sorting, e.g. Album > > 2. expand the leftmost arrow down, click Shuffle > > 3. the Album sorting is not reset (as it should be; other "normal" sorting > > items correctly rese

Jenkins build is back to normal : amarok_master #423

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Build failed in Jenkins: amarok_master #422

See Changes: [kretschmann] Add OpenGL analyzers, and make analyzers configurable (right-click). -- [...truncated 4373 lines...]

[amarok] /: Add OpenGL analyzers, and make analyzers configurable (right-click).

Git commit 7c139193a4fcb74a0a3cfdddbe85a3c1168f0de0 by Mark Kretschmann. Committed on 26/05/2013 at 10:49. Pushed by markey into branch 'master'. Add OpenGL analyzers, and make analyzers configurable (right-click). I've ported two OpenGL analyzers from Amarok 1.x. One of them shows a whirly backg

Re: Review Request 110101: fixes Bug 242256 - JJ: Make Magnatue service use KWallet for password storage

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110101/ --- (Updated May 30, 2013, 2:39 p.m.) Status -- This change has been disc

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/#review33423 --- Looks good, although I've spotted last error: 1. add a normal s