-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110101/
-----------------------------------------------------------
(Updated May 30, 2013, 2:39 p.m.)
Status
------
This change has been discarded.
Review request for Amarok.
Description
-------
Now Magnatue service uses KWallet for password storage rather than storing
passwords in plaintext in amarokrc. The patch is based on the LastFm service
settings (that uses KWallet) complete with a dialog to ask the user to store
password in plain text if KWallet does not exist/unavailable.
Contrary to before, now the save() method (of MegatuneConfig) runs
asynchronously so it may to be required to update other classes that call
methods of MegatuneConfig to connect to the updated() SIGNAL.
This addresses bug 242256.
https://bugs.kde.org/show_bug.cgi?id=242256
Diffs
-----
src/services/magnatune/MagnatuneConfig.h 552bcf8
src/services/magnatune/MagnatuneConfig.cpp 5842c63
Diff: http://git.reviewboard.kde.org/r/110101/diff/
Testing
-------
Testing done, works. Builds, runs and passes the build tests.
File Attachments
----------------
now megatune requests for KWallet
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/20/amarok_megatune_screenshot.png
Thanks,
Vedant Agarwala
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
