Re: amarok-devel@kde.org

Heya, Matěj Laitl wrote: > On 2. 4. 2013 Edward Toroshchin wrote: >> Well, I'm not a particular fan of bureaucracy myself, but why do we have >> a mailing list at all, if such a major thing is not even _announced_ >> there? > > First, I wouldn't consider this _major_ at all. Second: yes, I should

Re: amarok-devel@kde.org

Drop me from tha CC please. I don't have an opinion in what happens. On Tue, Apr 2, 2013 at 5:17 PM, Edward Toroshchin wrote: > Well, I'm not a particular fan of bureaucracy myself, but why do we have > a mailing list at all, if such a major thing is not even _announced_ > there? > > Also, when

Re: amarok-devel@kde.org

Don't heat this up with sophistics. Just don't forget to discuss major changes before implementing them. Or if you think there's no one to discuss them with, don't forget to notify whoever might be interested. That's my point. -- Edward "Hades" Toroshchin dr_lepper on irc.freenode.org __

Re: amarok-devel@kde.org

On 2. 4. 2013 Edward Toroshchin wrote: > Well, I'm not a particular fan of bureaucracy myself, but why do we have > a mailing list at all, if such a major thing is not even _announced_ > there? First, I wouldn't consider this _major_ at all. Second: yes, I should have told Daniel to add CCMAIL: a

Re: amarok-devel@kde.org

Well, I'm not a particular fan of bureaucracy myself, but why do we have a mailing list at all, if such a major thing is not even _announced_ there? Also, when did the discussion take place on the IRC? I'd love to see that "sane distribution" list for future reference. On Tue, Apr 02, 2013 at 09:

Re: amarok-devel@kde.org

On 2. 4. 2013 Edward Toroshchin wrote: > Guys, > > I don't quite remember discussing the Qt version bump. Given that this was only a minor version bump (4.8.0 -> 4.8.2) needed for some cleanup changes, I only said "go forward" on IRC. If there is a specific problem, this can be always reverted,

amarok-devel@kde.org

Guys, I don't quite remember discussing the Qt version bump. Is it just me? -- Edward "Hades" Toroshchin dr_lepper on irc.freenode.org >From e4aea888482646cc522234399f688e56f4e413e5 Mon Sep 17 00:00:00 2001 From: Daniel Meltzer Date: Fri, 29 Mar 2013 11:50:35 -0400 Subject: [PATCH] Bump Qt req

Jenkins build is back to stable : amarok_master #326

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109794: Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109794/ --- (Updated April 2, 2013, 6:06 p.m.) Status -- This change has been mar

Re: Review Request 109794: Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109794/#review30285 --- This review has been submitted with commit 7a72f13d7f57e83efda

Re: Review Request 109794: Fix spacing of SIGNAL and SLOT macros in connect() calls according to Amarok style guidelines

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109794/ --- (Updated April 2, 2013, 11:11 p.m.) Review request for Amarok. Changes -

Jenkins build became unstable: amarok_master #325

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 28, 2013, 6:33 p.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then get

Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

> On March 28, 2013, 4:44 p.m., Matěj Laitl wrote: > > Is there a wish request or any other motivation to implement this feature? > > I don't see many reasons why user should care that the lyrics have been > > just downloaded or already cached. On the other hand, user may want to know > > whet

Re: [amarok] src/dynamic: fix more i18n Krazy issues

On 2. 4. 2013 Matěj Laitl wrote: > On 2. 4. 2013 Myriam Schweingruber wrote: > > Git commit 601be3102ccb8ca78e3629f9d1b7696c2a535fa4 by Myriam > > Schweingruber. Committed on 02/04/2013 at 15:45. > > Pushed by schweingruber into branch 'master'. > > > > > > > > fix more i18n Krazy issues > > diff

Jenkins build is back to normal : amarok_master #324

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: [amarok] src/dynamic: fix more i18n Krazy issues

On 2. 4. 2013 Myriam Schweingruber wrote: > Git commit 601be3102ccb8ca78e3629f9d1b7696c2a535fa4 by Myriam Schweingruber. > Committed on 02/04/2013 at 15:45. > Pushed by schweingruber into branch 'master'. > > fix more i18n Krazy issues > diff --git a/src/dynamic/BiasFactory.cpp b/src/dynamic/BiasF

Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review30269 --- Ship it! Good work! Now I'll be happy to merge the updated ve

Build failed in Jenkins: amarok_master #322

See -- [...truncated 3256 lines...] [ 63%] Scanning dependencies of target testtrackset Building CXX object src/core-impl/collections/db/sql/CMakeFiles/amarok-sqlcollection.dir/SqlQueryMaker.o [ 63%] Building CX

Build failed in Jenkins: amarok_master #321

See Changes: [myriam] Add missing ), sorry for the noise -- [...truncated 3025 lines...] from :20, fr

Build failed in Jenkins: amarok_master #320

See Changes: [matej] Biggie: PlaylistFile refactoring, code deduplication, asynchronous loading [myriam] Fix some Krazy i18n errors -- [...truncated 1815 lines...] Building CXX object src/CMakeFiles/a

Re: [amarok] /: Biggie: PlaylistFile refactoring, code deduplication, asynchronous loading

Hi all, On Tue, Apr 2, 2013 at 12:47 PM, Matěj Laitl wrote: > Git commit 6f87755c9ab292dc0c590140f133dadead7304f3 by Matěj Laitl, on behalf > of Tatjana Gornak. > Committed on 02/04/2013 at 12:08. > Pushed by laitl into branch 'master'. > > Biggie: PlaylistFile refactoring, code deduplication, a

Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/ --- (Updated April 2, 2013, 10:47 a.m.) Status -- This change has been ma

Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review30255 --- This review has been submitted with commit 6f87755c9ab292dc0c5

Re: Review Request 107473: Changes in processing playlist files

> On April 2, 2013, 7:09 a.m., Bart Cerneels wrote: > > A suggestion: start a feature branch to work on this. Mucking about with > > patches is not very efficient. I think you 2 can discuss the code in > > details without the help of reviewboard by now. And before merging you can > > upload it

Re: Review Request 107473: Changes in processing playlist files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/#review30244 --- A suggestion: start a feature branch to work on this. Mucking a