On 2. 4. 2013 Matěj Laitl wrote:
> On 2. 4. 2013 Myriam Schweingruber wrote:
> > Git commit 601be3102ccb8ca78e3629f9d1b7696c2a535fa4 by Myriam
> > Schweingruber. Committed on 02/04/2013 at 15:45.
> > Pushed by schweingruber into branch 'master'.
> >
> >
> >
> > fix more i18n Krazy issues
> > diff --git a/src/dynamic/BiasFactory.cpp b/src/dynamic/BiasFactory.cpp
> > index d0cdb0d..77d8d76 100644
> > --- a/src/dynamic/BiasFactory.cpp
> > +++ b/src/dynamic/BiasFactory.cpp
> >
> > QWidget*
> > Dynamic::ReplacementBias::widget( QWidget* parent )
> > {
> >
> > - QLabel *label = new QLabel( i18n( "Replacement for bias %1" ).arg(
> > m_name ), parent );
> > + QLabel *label = new QLabel( i18n( "Replacement for
> > bias %1", m_name, parent ) );
>
> This is incorrect. parent should be an argument of QLabel, not i18n(). This
> change thus introduces a memory leak. Please fix this in a follow-up
> commit.
Now I see this has been already fixed. (I would notice it faster if the commit
was named "Fix previous commit" rather than "more Krazy i18n fixes")
Matěj
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
