Re: Trying to solve bug 240409

2013-02-18 Thread Abhinandan Ramprasath
This is what I've got so far, 1) mp4v2-2.0.0 supports chapters in mp4 files(mentioned on comment 2). The format for chapter storage is specified between lines 2321 and 2375 under src/mp4file.cpp ( http://code.google.com/p/mp4v2/downloads/detail?name=mp4v2-2.0.0.tar.bz2 ) . 2) comment 2 in https:/

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108686/#review27666 --- This review has been submitted with commit 0165a65a657ebd02ac7

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Thomas Pfeiffer
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Trying to solve bug 240409

2013-02-18 Thread Matěj Laitl
On 19. 2. 2013 Abhinandan Ramprasath wrote: > To solve the bug https://bugs.kde.org/show_bug.cgi?id=240409, Bug 240409 - be warned that it may turn out harder than expected, I dunno who marked it as a junior job. ;) > I was > thinking I could create a MultiTrack (Meta::MultiTrack) list with all

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Thomas Pfeiffer
On Monday 18 February 2013 18:37:21 Myriam Schweingruber wrote: > Thomas, this is about http://git.reviewboard.kde.org/r/108686/ > > On Mon, Feb 18, 2013 at 3:29 PM, Edward Hades Toroshchin > > wrote: > > On Mon, Feb 18, 2013 at 02:22:14PM -, Bart Cerneels wrote: > >> Yes I am, it's nice and

Re: Trying to solve bug 240409

2013-02-18 Thread Abhinandan Ramprasath
To solve the bug https://bugs.kde.org/show_bug.cgi?id=240409 , I was thinking I could create a MultiTrack (Meta::MultiTrack) list with all the chapters in a list one below the other and setting offsets to each chapter in the m4b file(which I still haven't figured out how). I do have a few question

Re: Trying to solve bug 240409

2013-02-18 Thread Abhinandan Ramprasath
It works :) thanks a lot! On Mon, Feb 18, 2013 at 11:30 PM, Myriam Schweingruber wrote: > On Mon, Feb 18, 2013 at 6:53 PM, Abhinandan Ramprasath > wrote: > > Thanks for the reply. However, It looks like a lot of the pages under > > http://community.kde.org/Development/ are unavailable, so are th

Re: Review Request 108964: Added 3 different seek options (with customizable seek lengths)

2013-02-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108964/#review27646 --- Technically correct patch, but please address the remarks below

Re: Trying to solve bug 240409

2013-02-18 Thread Abhinandan Ramprasath
Thanks for the reply. However, It looks like a lot of the pages under http://community.kde.org/Development/ are unavailable, so are there some old documentations online I can get hold of? On Mon, Feb 18, 2013 at 11:12 PM, Myriam Schweingruber wrote: > Hi

Re: Trying to solve bug 240409

2013-02-18 Thread Myriam Schweingruber
On Mon, Feb 18, 2013 at 6:53 PM, Abhinandan Ramprasath wrote: > Thanks for the reply. However, It looks like a lot of the pages under > http://community.kde.org/Development/ are unavailable, so are there some old > documentations online I can get hold of? Oops, my bad, I typed that manually, here

Re: Trying to solve bug 240409

2013-02-18 Thread Myriam Schweingruber
Hi Abinandan. On Mon, Feb 18, 2013 at 5:56 PM, Abhinandan Ramprasath wrote: > Hi, > > I was looking at the junior jobs at the bug tracker and bug 240409 really > caught my eye. > > Thanks, > > Abhinandan > > ___ > Amarok-devel mailing list > Amarok-deve

Re: [amarok] src: Remove unused AudioCdTrackProvider

2013-02-18 Thread Matěj Laitl
On 18. 2. 2013 Bart Cerneels wrote: > On Sun, Feb 17, 2013 at 6:39 PM, Matěj Laitl wrote: > > Git commit d6251e08012056b1e3920edb7ae2d451bcdf9218 by Matěj Laitl. > > > > Remove unused AudioCdTrackProvider > > Wasn't this part of AudioCdCollection? How did that ever work? AudioCdCollection is a

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Matěj Laitl
On 18. 2. 2013 Edward Hades Toroshchin wrote: > On Mon, Feb 18, 2013 at 02:22:14PM -, Bart Cerneels wrote: > > Yes I am, it's nice and cool here. Don't have much chance to check the > > commits though. Shouldn't this review have been closed already? > > Guys, I propose using our mailing list m

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Myriam Schweingruber
Thomas, this is about http://git.reviewboard.kde.org/r/108686/ On Mon, Feb 18, 2013 at 3:29 PM, Edward Hades Toroshchin wrote: > On Mon, Feb 18, 2013 at 02:22:14PM -, Bart Cerneels wrote: >> Yes I am, it's nice and cool here. Don't have much chance to check the >> commits though. Shouldn't th

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Matěj Laitl
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Bart Cerneels
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Trying to solve bug 240409

2013-02-18 Thread Abhinandan Ramprasath
Hi, I was looking at the junior jobs at the bug tracker and bug 240409 really caught my eye. I spend a lot of time searching the code on where to start, but couldn't really get anywhere. so i was wondering if there is a book or guide that would help me find definitions of classes. Any pointers on

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Bart Cerneels
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases

Re: Review Request 108542: Support for .opus file tags added

2013-02-18 Thread Mathias Panzenböck
On 02/18/2013 03:12 PM, Matěj Laitl wrote: On 17. 2. 2013 Mathias Stephan Panzenböck wrote: On February 9th, 2013, 1:17 a.m. UTC, Matěj Laitl wrote: shared/FileTypeResolver.cpp (Diff revision 2) 20 #include "config.h" Why is including config.h needed for TAGLIB_OPUS_FOUND while it isn't needed

Re: Review Request 108542: Support for .opus file tags added

2013-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108542/#review27638 --- This review has been submitted with commit abd5c3ff4051c77075b

Re: Review Request 108542: Support for .opus file tags added

2013-02-18 Thread Matěj Laitl
On 17. 2. 2013 Mathias Stephan Panzenböck wrote: > On February 9th, 2013, 1:17 a.m. UTC, Matěj Laitl wrote: > > shared/FileTypeResolver.cpp (Diff revision 2) > > 20 #include "config.h" > > > > Why is including config.h needed for TAGLIB_OPUS_FOUND while it isn't > > needed for TAGLIB_MOD_FOUND? >

Re: [amarok] src: Remove unused AudioCdTrackProvider

2013-02-18 Thread Bart Cerneels
Wasn't this part of AudioCdCollection? How did that ever work? On Sun, Feb 17, 2013 at 6:39 PM, Matěj Laitl wrote: > Git commit d6251e08012056b1e3920edb7ae2d451bcdf9218 by Matěj Laitl. > Committed on 17/02/2013 at 18:38. > Pushed by laitl into branch 'master'. > > Remove unused AudioCdTrackProvid

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Bart Cerneels
On Mon, Feb 18, 2013 at 3:29 PM, Edward Hades Toroshchin wrote: > On Mon, Feb 18, 2013 at 02:22:14PM -, Bart Cerneels wrote: >> Yes I am, it's nice and cool here. Don't have much chance to check the >> commits though. Shouldn't this review have been closed already? > > Guys, I propose using ou

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Edward Hades Toroshchin
On Mon, Feb 18, 2013 at 02:22:14PM -, Bart Cerneels wrote: > Yes I am, it's nice and cool here. Don't have much chance to check the > commits though. Shouldn't this review have been closed already? Guys, I propose using our mailing list more, and IRC less. Otherwise such things happen: we disc

Re: Review Request 108686: hidden items in context menu: usability question

2013-02-18 Thread Heiko Tietze
> On Feb. 1, 2013, 2:58 a.m., Wyatt Epp wrote: > > "What would be the best approach here?" > > > > Frankly? Scrap it; this is not good interaction. Context menus are rarely > > modifier modal and that's being generous (I have never seen one before > > now). Excepting a very few special cases