On 17. 2. 2013 Mathias Stephan Panzenböck wrote:
> On February 9th, 2013, 1:17 a.m. UTC, Matěj Laitl wrote:
> > shared/FileTypeResolver.cpp (Diff revision 2)
> > 20 #include "config.h"
> >
> > Why is including config.h needed for TAGLIB_OPUS_FOUND while it isn't
> > needed for TAGLIB_MOD_FOUND?
> >
> > Martin Brodbeck wrote:
> >
> > That's a good question. Are you sure that the TAGLIB_MOD_FOUND part
> > compiles? Here, for the OPUS stuff, I need the include.
>
> The TAGLIB_MOD_FOUND part works for me, when compiling against TagLib 1.8.x.
> But everywhere where this macro is used there is config.h already included
> (shared/FileTypeResolver.cpp and shared/tag_helpers/TagHelper.cpp):
> http://quickgit.kde.org/?p=amarok.git&a=blob&h=cd531d55771e7d4bed90fa36abae
> 96cae6b59ad1&hb=a9455a6348d9095528a222727755a105cc782812&f=shared%2FFileType
> Resolver.cpp
Because I've fixed it a few commits earlier, in v2.7.0-69-ga99144e (you were
looking at v2.7.0-78-ga9455a6). :-)
Matěj
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
