> On 2010-11-29 22:53:02, Leo Franchi wrote:
> > Looks good to me now! I'd just shrink it a bit more.. the ratio is still
> > fine, but the dialog is still quite large. There's room for 50+ queued
> > tracks,that seems like overkill
Pushed, thanks. (With a slightly smaller dialog)
- Andr
> On 2010-11-28 00:19:48, Leo Franchi wrote:
> > Sorry for the lack of review. Looks good to me. Do you have git push access
> > or should I commit for you?
Ok, pushed. Thanks!
- Leo
---
This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100176/#review443
---
Ship it!
I don't have a DAAP server to test, but on a first look
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100177/#review442
---
Ship it!
Looks good to me now! I'd just shrink it a bit more.. t
Our latest "Last Week in Amarok" article has been released.
Enjoy:
http://amarok.kde.org/blog/archives/1200-Last-Week-in-Amarok.html
:)
--
Mark Kretschmann
Amarok Developer, Software Engineer at KO GmbH
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://fsfe.org - ht
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100177/
---
(Updated 2010-11-29 18:11:59.652854)
Review request for Amarok.
Changes
> On 2010-11-29 17:48:18, Bart Cerneels wrote:
> > I integrated the patch but did change a few lines:
> > 1) Added copyright info since the generateName function is non-trivial.
> > 2) Removed the date from the single artist, single album case.
> > 3) Fixed some potential i18n issues.
> >
> > Th
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100177/
---
(Updated 2010-11-29 17:49:53.425707)
Review request for Amarok.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100168/#review440
---
Ship it!
I integrated the patch but did change a few lines:
1) A
