-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100177/
-----------------------------------------------------------
(Updated 2010-11-29 17:49:53.425707)
Review request for Amarok.
Changes
-------
Commit messages of this updated diff:
- Queue Editor: Fix clear button icon. Make initial size smaller.
- Show artist *and* track for songs in the queue editor
- Update the queue editor on track progression
- Don't use an index that is strictly speaking invalid after reloading
the queue list view, use the quint 64 id. Restore the current item also
after responding to externally generated queue changes.
- More suitable and better looking initial size for queue editor.
The aspect ratio is roughly the golden ratio :)
- Update the playlist on changes in the queue editor
- Codingstyle: return types on their own lines
- Put the edit queue action next to the other actions in the middle
- Use a more suitable icon for the queue editor action
Summary
-------
This adds a Queue Editor, with limited features (move up / move down / clear)
like in Amarok 1.
The KAction for it is not very well placed in the main UI, I hope you guys can
help me.
A few design changes were necessary, too, as you can see in the patch.
This addresses bug 198180.
https://bugs.kde.org/show_bug.cgi?id=198180
Diffs (updated)
-----
src/CMakeLists.txt c5ee1e3
src/MainWindow.cpp f755b6f
src/likeback/LikeBackBar.cpp 6964f88
src/playlist/PlaylistActions.h a0b2275
src/playlist/PlaylistActions.cpp d9284e7
src/playlist/PlaylistController.cpp f05c250
src/playlist/PlaylistDock.h f7f1231
src/playlist/PlaylistDock.cpp 6170f78
src/playlist/PlaylistItem.h 6bfeb68
src/playlist/PlaylistModel.h 7b7633f
src/playlist/PlaylistModel.cpp 0162321
src/playlist/PlaylistQueueEditor.h PRE-CREATION
src/playlist/PlaylistQueueEditor.cpp PRE-CREATION
src/playlist/PlaylistQueueEditor.ui PRE-CREATION
src/playlist/navigators/DynamicTrackNavigator.cpp a1c67e7
src/playlist/navigators/StandardTrackNavigator.cpp faeb9f7
src/playlist/navigators/TrackNavigator.h 6154f9a
src/playlist/navigators/TrackNavigator.cpp 2a70b08
src/playlist/proxymodels/AbstractModel.h 03ca4d6
src/playlist/proxymodels/ProxyBase.h 2e6f9e7
src/playlist/proxymodels/ProxyBase.cpp 37cb8cb
src/playlist/view/PlaylistViewCommon.cpp 2a5c9f6
src/playlist/view/listview/PrettyItemDelegate.cpp 5494279
src/playlist/view/listview/PrettyListView.cpp 0b2e41e
src/statusbar/StatusBar.cpp 1a67677
Diff: http://git.reviewboard.kde.org/r/100177/diff
Testing
-------
"worksforme"
Thanks,
Andreas
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
