Re: [Amarok] d875d9d: Fix crash in about dialog

On Tue, Nov 23, 2010 at 4:07 PM, Daniel Faust wrote: > commit d875d9d84a2e8274d675aa7a3124523f19f72bf7 > branch master > Author: Daniel Faust > Date:   Tue Nov 23 16:06:48 2010 +0100 > >    Fix crash in about dialog [snip] > +    QPointer m_showOcsDonorButton; Please don't use QPointer any mor

Re: Review Request: Use MetaQueryWidget in the advanced playlist generator.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100070/#review412 --- After adding two small changes from Daniel Faust this is finally

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review411 --- Ship it! Well, now It looks good for me. But here http://pastebi

Re: Review Request: Up/down key track selection while using progressive search widget

> On 2010-11-21 20:28:48, Leo Franchi wrote: > > +1 from me too. Do you have a git account, or should we push for you? > > Thomas Karpiniec wrote: > I'm pretty sure I don't. If you could push it for me that would be great, > thanks. :) Great. Pushed, thanks for the patch! - Leo ---

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/ --- (Updated 2010-11-25 21:45:23.270919) Review request for Amarok. Changes

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

> On 2010-11-25 12:33:13, Sergey Ivanov wrote: > > You got me wrong. I meant you should check albums and artists for > > existence, not for empty name. Because ArtistPtr/AlbumPtr can point to > > nowhere in case of NULL artist/album in DB. Oops.. Completely missed that ! Thnx. - Dennis ---

Re: New "Last Week in Amarok" article

On 11/25/2010 5:37 AM, Valorie Zimmerman wrote: > On Thu, Nov 25, 2010 at 2:10 AM, Mark Kretschmann wrote: >> On Wed, Nov 24, 2010 at 6:25 PM, Mark Kretschmann >> wrote: >>> Folks, >>> >>> Myriam has created a new document for our "Last Week in Amarok" >>> series. For some reason, the mail notif

Re: Review Request: Merge tag reading and writing into one file.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100169/#review406 --- Ship it! I've been thinking about It, but you made It first. :)

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review407 --- You got me wrong. I meant you should check albums and artists for

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

> On 2010-11-25 10:04:30, Sergey Ivanov wrote: > > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp, line 274 > > > > > > What's a point to pass name to function, if you can return It from > > there, It made sense

Review Request: Merge tag reading and writing into one file.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100169/ --- Review request for Amarok. Summary --- Move the slightly different co

Re: New "Last Week in Amarok" article

On Thu, Nov 25, 2010 at 11:10, Mark Kretschmann wrote: > On Wed, Nov 24, 2010 at 6:25 PM, Mark Kretschmann wrote: >> Folks, >> >> Myriam has created a new document for our "Last Week in Amarok" >> series. For some reason, the mail notification sending did not work, >> so I'm posting the link here

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review402 --- Thanks for the patch. I'm sure this feature will be much loved by

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

> On 2010-11-25 10:04:30, Sergey Ivanov wrote: > > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp, line 274 > > > > > > What's a point to pass name to function, if you can return It from > > there, It made sense

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

> On 2010-11-25 10:04:30, Sergey Ivanov wrote: > > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp, line 274 > > > > > > What's a point to pass name to function, if you can return It from > > there, It made sense

Re: New "Last Week in Amarok" article

On Thu, Nov 25, 2010 at 2:10 AM, Mark Kretschmann wrote: > On Wed, Nov 24, 2010 at 6:25 PM, Mark Kretschmann wrote: >> Folks, >> >> Myriam has created a new document for our "Last Week in Amarok" >> series. For some reason, the mail notification sending did not work, >> so I'm posting the link he

Crash on Exit

Hey all, I've been having this crash, kinda randomly, for a while. Any ideas? I'm not sure if this is Amarok's fault, or maybe Phonon-VLC? Thread 1 (Thread 0x7f7985d3d780 (LWP 7236)): [KCrash Handler] #6 __pthread_mutex_lock (mutex=0x0) at pthread_mutex_lock.c:50 #7 0x7f7982345ba7 in XrmDe

Re: New "Last Week in Amarok" article

On Wed, Nov 24, 2010 at 6:25 PM, Mark Kretschmann wrote: > Folks, > > Myriam has created a new document for our "Last Week in Amarok" > series. For some reason, the mail notification sending did not work, > so I'm posting the link here: > > https://docs.google.com/document/d/1L7Rb_N0UXGjvqLoLxj5lq

Re: Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review401 --- src/playlistmanager/sql/SqlUserPlaylistProvider.cpp