-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100168/
-----------------------------------------------------------
(Updated 2010-11-25 21:45:23.270919)
Review request for Amarok.
Changes
-------
Made changes based on what I understood from Sergey's and Bart's comments.
Hope I got it right this time.
Summary
-------
The playlist name is generated as per the rules :
if ( singleArtist && singleAlbum )
playlistName = artist + " - " + album + ' - ' + shortDate
else if ( !singleArtist && singleAlbum )
playlistName = "Various" + " - " + album + ' - ' + shortDate
else if ( singleArtist && !singleAlbum )
playlistName = artist + " - " + "Various" + shortDate
else
playlistName = "Various" + " - " + shortDate
If the there are no tracks, the playlist name is set to "Empty Playlist - " +
shortDate
This addresses bug 185397.
https://bugs.kde.org/show_bug.cgi?id=185397
Diffs (updated)
-----
src/playlist/PlaylistDock.cpp f781528
src/playlist/PlaylistModel.h 7b7633f
src/playlist/PlaylistModel.cpp 0162321
Diff: http://git.reviewboard.kde.org/r/100168/diff
Testing
-------
Tested different possibilities. It is working fine for me.
Please suggest better alternatives ( if any ) to the shortDate addition.
Without the shortDate, playlist database lookup would be necessary to
calculate a unique name.
Thanks,
Dennis
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
