----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review402 -----------------------------------------------------------
Thanks for the patch. I'm sure this feature will be much loved by many amarok users. I do have one big request: Currently this code is only used when a playlist is saved in the database. This is only one, albeit the default, playlistprovider. We also support saving to a playlist-file (in the $KDEHOME/share/apps/amarok/playlists) and to attached media players. In the future we will be able to save a playlist to online services as well. Looking at the code there is no single SQL specific function used, hence this is just a cut and paste job. In short: I want this function moved to outside the SqlPlaylist classes and into the playlist-view, perhaps PlaylistModel.cpp, so it can be called from Playlist::Dock::slotSaveCurrentPlaylist(). When integrating this patch I'll also change the export playlist functionality to do the same. - Bart On 2010-11-25 01:01:23, Dennis Francis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100168/ > ----------------------------------------------------------- > > (Updated 2010-11-25 01:01:23) > > > Review request for Amarok. > > > Summary > ------- > > The playlist name is generated as per the rules : > > if ( singleArtist && singleAlbum ) > playlistName = artist + " - " + album + ' - ' + shortDate > > else if ( !singleArtist && singleAlbum ) > playlistName = "Various" + " - " + album + ' - ' + shortDate > > else if ( singleArtist && !singleAlbum ) > playlistName = artist + " - " + "Various" + shortDate > > else > playlistName = "Various" + " - " + shortDate > > If the there are no tracks, the playlist name is set to "Empty Playlist - " + > shortDate > > > This addresses bug 185397. > https://bugs.kde.org/show_bug.cgi?id=185397 > > > Diffs > ----- > > src/playlistmanager/sql/SqlUserPlaylistProvider.h 3a5a62e > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp d2ae5b9 > > Diff: http://git.reviewboard.kde.org/r/100168/diff > > > Testing > ------- > > Tested different possibilities. It is working fine for me. > > Please suggest better alternatives ( if any ) to the shortDate addition. > Without the shortDate, playlist database lookup would be necessary to > calculate a unique name. > > > Thanks, > > Dennis > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
